summaryrefslogtreecommitdiff
path: root/buildscripts
diff options
context:
space:
mode:
authorDavid Bradford <david.bradford@mongodb.com>2021-07-15 09:21:22 -0400
committerEvergreen Agent <no-reply@evergreen.mongodb.com>2021-07-15 14:13:28 +0000
commit34116ccb3c6fa3187017f84b424979d8a1f0e33d (patch)
treee6971686028208de02363c85fd1d6c8a5c7d72af /buildscripts
parent89fb792bbb145173f1c6d3e7a12419cfb580ce17 (diff)
downloadmongo-34116ccb3c6fa3187017f84b424979d8a1f0e33d.tar.gz
SERVER-58576 Improve build variant task gen unit tests
Diffstat (limited to 'buildscripts')
-rw-r--r--buildscripts/evergreen_gen_build_variant.py5
-rw-r--r--buildscripts/tests/test_evergreen_gen_build_variant.py3
2 files changed, 5 insertions, 3 deletions
diff --git a/buildscripts/evergreen_gen_build_variant.py b/buildscripts/evergreen_gen_build_variant.py
index 4bf805d0122..65597d5aa4d 100644
--- a/buildscripts/evergreen_gen_build_variant.py
+++ b/buildscripts/evergreen_gen_build_variant.py
@@ -389,7 +389,7 @@ class GenerateBuildVariantOrchestrator:
LOGGER.info("Configure task", task_id=task.task_id, priority=priority)
self.evg_api.configure_task(task.task_id, priority=priority)
- def adjust_gen_tasks_priority(self, gen_tasks: Set[str]) -> None:
+ def adjust_gen_tasks_priority(self, gen_tasks: Set[str]) -> int:
"""
Increase the priority of any "_gen" tasks.
@@ -407,7 +407,8 @@ class GenerateBuildVariantOrchestrator:
if task.display_name in gen_tasks
]
- [j.result() for j in jobs] # pylint: disable=expression-not-assigned
+ results = [j.result() for j in jobs]
+ return len(results)
@click.command()
diff --git a/buildscripts/tests/test_evergreen_gen_build_variant.py b/buildscripts/tests/test_evergreen_gen_build_variant.py
index a2fa41bd5db..e14689a3169 100644
--- a/buildscripts/tests/test_evergreen_gen_build_variant.py
+++ b/buildscripts/tests/test_evergreen_gen_build_variant.py
@@ -300,6 +300,7 @@ class TestAdjustGenTasksPriority(unittest.TestCase):
]
mock_orchestrator = build_mock_orchestrator(build_task_list=mock_task_list)
- mock_orchestrator.adjust_gen_tasks_priority(gen_tasks)
+ n_tasks_adjusted = mock_orchestrator.adjust_gen_tasks_priority(gen_tasks)
+ self.assertEqual(len(gen_tasks), n_tasks_adjusted)
self.assertEqual(len(gen_tasks), mock_orchestrator.evg_api.configure_task.call_count)