SERVER-50761 Crash the shell on invalid BSON errors on server responses from outgoing connections in

all of the jstestfuzz test suites.

Combine a new shell parameter --crashOnInvalidBSONError with --objcheck in the shell for all
jstestfuzz test suites. --objcheck in the shell turns on BSON validation on responses from outgoing
connections to the server. --crashOnInvalidBSONError crashes the shell if that extra BSON validation
encounters an error, and attempts to log the invalid BSON for debugging.

13 files changed, 30 insertions, 2 deletions

diff --git a/buildscripts/resmokeconfig/suites/core.yml b/buildscripts/resmokeconfig/suites/core.yml
index f0b374bc672..23a08a1b47d 100644
--- a/buildscripts/resmokeconfig/suites/core.yml
+++ b/buildscripts/resmokeconfig/suites/core.yml
@@ -14,6 +14,8 @@ executor:
       - ValidateCollections
   config:
     shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       eval: load("jstests/libs/override_methods/detect_spawning_own_mongod.js");
   hooks:
   - class: ValidateCollections
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz.yml b/buildscripts/resmokeconfig/suites/jstestfuzz.yml
index 0db4c0d0f72..88e55cfa817 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz.yml
@@ -8,7 +8,10 @@ executor:
   archive:
     hooks:
       - ValidateCollections
-  config: {}
+  config:
+    shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   - class: ValidateCollections
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt.yml
index f618ebd99d5..2fc080709e9 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt.yml
@@ -14,6 +14,8 @@ executor:
         TestData:
           checkForInterruptFailpointChance: 0.05
       eval: load('jstests/libs/jstestfuzz/check_for_interrupt_hook.js')
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   - class: ValidateCollections
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt_replication.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt_replication.yml
index 10bc6144747..06acf568150 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt_replication.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_interrupt_replication.yml
@@ -16,6 +16,8 @@ executor:
         TestData:
           checkForInterruptFailpointChance: 0.05
       eval: load('jstests/libs/jstestfuzz/check_for_interrupt_hook.js')
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_replication.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_replication.yml
index 7bcfaec532f..dbfb57b6ad0 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_replication.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_replication.yml
@@ -12,6 +12,8 @@ executor:
       - ValidateCollections
   config:
     shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       global_vars:
         TestData:
           # Other fuzzers test commands against replica sets with logical session ids.
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_continuous_stepdown.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_continuous_stepdown.yml
index 34b46926943..fd02b4c7989 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_continuous_stepdown.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_continuous_stepdown.yml
@@ -11,6 +11,8 @@ executor:
       - ValidateCollections
   config:
     shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       global_vars:
         TestData:
           ignoreCommandsIncompatibleWithRollback: true
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_initsync.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_initsync.yml
index 8eed6daeb99..1223252bfb0 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_initsync.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_initsync.yml
@@ -10,6 +10,8 @@ executor:
       - BackgroundInitialSync
   config:
     shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       global_vars:
         TestData:
           ignoreCommandsIncompatibleWithInitialSync: true
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_session.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_session.yml
index 5349d88ffeb..dd80eb713ac 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_session.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_session.yml
@@ -13,6 +13,8 @@ executor:
   config:
     shell_options:
       eval: load("jstests/libs/override_methods/enable_sessions.js")
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   # The CheckReplDBHash hook waits until all operations have replicated to and have been applied
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_write_conflicts.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_write_conflicts.yml
index bfb8f6deca3..3346e6236b2 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_replication_write_conflicts.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_replication_write_conflicts.yml
@@ -8,7 +8,10 @@ executor:
   archive:
     hooks:
       - ValidateCollections
-  config: {}
+  config:
+    shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: EnableSpuriousWriteConflicts
     shell_options:
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded.yml
index f1c722aa85f..9ae37bd2b47 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded.yml
@@ -15,6 +15,8 @@ executor:
         TestData:
           # Other fuzzers test commands against sharded clusters with logical session ids.
           disableImplicitSessions: true
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   - class: CheckReplDBHash
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_causal_consistency.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_causal_consistency.yml
index c1451d4dd29..bb5f072fa48 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_causal_consistency.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_causal_consistency.yml
@@ -12,6 +12,8 @@ executor:
   config:
     shell_options:
       eval: load("jstests/libs/override_methods/enable_causal_consistency.js")
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       global_vars:
         TestData:
           runningWithCausalConsistency: true
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_continuous_stepdown.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_continuous_stepdown.yml
index c2162c21abe..a23d7f76642 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_continuous_stepdown.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_continuous_stepdown.yml
@@ -11,6 +11,8 @@ executor:
       - ValidateCollections
   config:
     shell_options:
+      crashOnInvalidBSONError: ""
+      objcheck: ""
       global_vars:
         TestData:
           runningWithConfigStepdowns: true
diff --git a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_session.yml b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_session.yml
index 5701e67acd5..a827c640e07 100644
--- a/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_session.yml
+++ b/buildscripts/resmokeconfig/suites/jstestfuzz_sharded_session.yml
@@ -12,6 +12,8 @@ executor:
   config:
     shell_options:
       eval: load("jstests/libs/override_methods/enable_sessions.js")
+      crashOnInvalidBSONError: ""
+      objcheck: ""
   hooks:
   - class: FuzzerRestoreSettings
   - class: CheckReplDBHash