SERVER-23202: Query planner does not trim certain bounds-generating inequality predicates from expression tree

1 files changed, 61 insertions, 0 deletions

diff --git a/jstests/core/index_bounds_object.js b/jstests/core/index_bounds_object.js
new file mode 100644
index 00000000000..22a7f433efd
--- /dev/null
+++ b/jstests/core/index_bounds_object.js
@@ -0,0 +1,61 @@
+// Index bounds generation tests for Object values.
+// @tags: [requires_non_retryable_writes, assumes_unsharded_collection]
+(function() {
+    "use strict";
+
+    load("jstests/libs/analyze_plan.js");  // For assertCoveredQueryAndCount.
+
+    const coll = db.index_bounds_object;
+    coll.drop();
+
+    assert.commandWorked(coll.createIndex({a: 1}));
+    assert.writeOK(coll.insert({a: {b: 1}}));
+
+    // Test that queries involving comparison operators with objects are covered.
+    const proj = {a: 1, _id: 0};
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gt: {b: 0}}}, project: proj, count: 1});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gt: {b: 2}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gte: {b: 1}}}, project: proj, count: 1});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gte: {b: 1, c: 2}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$lt: {b: 2}}}, project: proj, count: 1});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$lte: {b: 1}}}, project: proj, count: 1});
+
+    // Test that queries involving comparisons with an empty object are covered.
+    assert.writeOK(coll.insert({a: {}}));
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$gt: {}}}, project: proj, count: 1});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$gte: {}}}, project: proj, count: 2});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$lt: {}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$lte: {}}}, project: proj, count: 1});
+
+    // Test that queries involving comparisons with a range of objects are covered.
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gt: {}, $lt: {b: 2}}}, project: proj, count: 1});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$gte: {}, $lt: {b: 2}}}, project: proj, count: 2});
+    assertCoveredQueryAndCount(
+        {collection: coll, query: {a: {$lt: {}, $gte: {}}}, project: proj, count: 0});
+
+    // Test that documents that lie outside of the generated index bounds are not returned. Cannot
+    // test empty array upper bounds since that would force the index to be multi-key.
+    coll.remove({});
+    assert.writeOK(coll.insert({a: "string"}));
+    assert.writeOK(coll.insert({a: true}));
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$gt: {}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$gte: {}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$lt: {}}}, project: proj, count: 0});
+    assertCoveredQueryAndCount({collection: coll, query: {a: {$lte: {}}}, project: proj, count: 0});
+
+    // Adding a document containing an array makes the index multi-key which can never be used for a
+    // covered query.
+    assert.writeOK(coll.insert({a: []}));
+    assert(!isIndexOnly(db, coll.find({a: {$gt: {}}}, proj).explain().queryPlanner.winningPlan));
+    assert(!isIndexOnly(db, coll.find({a: {$gte: {}}}, proj).explain().queryPlanner.winningPlan));
+    assert(!isIndexOnly(db, coll.find({a: {$lt: {}}}, proj).explain().queryPlanner.winningPlan));
+    assert(!isIndexOnly(db, coll.find({a: {$lte: {}}}, proj).explain().queryPlanner.winningPlan));
+})();