SERVER-25889 Collection validation should fail if featureCompatibilityVersion is 3.2 and the collection contains NumberDecimal values

1 files changed, 30 insertions, 0 deletions

diff --git a/jstests/hooks/validate_collections.js b/jstests/hooks/validate_collections.js
index eac734b4d61..89c7f73e798 100644
--- a/jstests/hooks/validate_collections.js
+++ b/jstests/hooks/validate_collections.js
@@ -13,6 +13,19 @@ function validateCollections(db, obj) {
         }
     }
 
+    function getFeatureCompatibilityVersion(adminDB) {
+        var res = adminDB.system.version.findOne({_id: "featureCompatibilityVersion"});
+        if (res === null) {
+            return "3.2";
+        }
+        return res.version;
+    }
+
+    function setFeatureCompatibilityVersion(adminDB, version) {
+        assert.commandWorked(adminDB.runCommand({setFeatureCompatibilityVersion: version}));
+        assert.eq(version, getFeatureCompatibilityVersion(adminDB));
+    }
+
     assert.eq(typeof db, 'object', 'Invalid `db` object, is the shell connected to a mongod?');
     assert.eq(typeof obj, 'object', 'The `obj` argument must be an object');
     assert(obj.hasOwnProperty('full'), 'Please specify whether to use full validation');
@@ -21,6 +34,17 @@ function validateCollections(db, obj) {
 
     var success = true;
 
+    var adminDB = db.getSiblingDB("admin");
+
+    // Set the featureCompatibilityVersion to its required value for performing validation. Save the
+    // original value.
+    var originalFeatureCompatibilityVersion;
+    if (jsTest.options().forceValidationWithFeatureCompatibilityVersion) {
+        originalFeatureCompatibilityVersion = getFeatureCompatibilityVersion(adminDB);
+        setFeatureCompatibilityVersion(
+            adminDB, jsTest.options().forceValidationWithFeatureCompatibilityVersion);
+    }
+
     // Don't run validate on view namespaces.
     let listCollectionsRes = db.runCommand({listCollections: 1, filter: {"type": "collection"}});
     if (jsTest.options().skipValidationOnInvalidViewDefinitions && listCollectionsRes.ok === 0) {
@@ -42,5 +66,11 @@ function validateCollections(db, obj) {
             success = false;
         }
     }
+
+    // Restore the original value for featureCompatibilityVersion.
+    if (jsTest.options().forceValidationWithFeatureCompatibilityVersion) {
+        setFeatureCompatibilityVersion(adminDB, originalFeatureCompatibilityVersion);
+    }
+
     return success;
 }