SERVER-41989 Fix exception safety in `BSONObjBuilder::asTempObj`.

The setting of `_doneCalled` too early allows for it to remain set
after an exception is thrown.  This will cause invariant violations
under some conditions.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/mongo/bson/bsonobjbuilder.cpp b/src/mongo/bson/bsonobjbuilder.cpp
index e2d56cb540e..369f307beb4 100644
--- a/src/mongo/bson/bsonobjbuilder.cpp
+++ b/src/mongo/bson/bsonobjbuilder.cpp
@@ -239,7 +239,7 @@ BSONObjBuilder::~BSONObjBuilder() {
 }
 
 template <typename Alloc>
-void _BufBuilder<Alloc>::grow_reallocate(int minSize) {
+void BasicBufBuilder<Alloc>::grow_reallocate(int minSize) {
     if (minSize > BufferMaxSize) {
         std::stringstream ss;
         ss << "BufBuilder attempted to grow() to " << minSize << " bytes, past the 64MB limit.";
@@ -254,8 +254,8 @@ void _BufBuilder<Alloc>::grow_reallocate(int minSize) {
     size = a;
 }
 
-template class _BufBuilder<SharedBufferAllocator>;
-template class _BufBuilder<StackAllocator>;
+template class BasicBufBuilder<SharedBufferAllocator>;
+template class BasicBufBuilder<StackAllocator>;
 template class StringBuilderImpl<SharedBufferAllocator>;
 template class StringBuilderImpl<StackAllocator>;