SERVER-6908 Don't pass strings by value

Change lots of code to take <string> arguments by const ref instead
of by value; minor changes to surrounding code.

1 files changed, 5 insertions, 2 deletions

diff --git a/src/mongo/client/syncclusterconnection.h b/src/mongo/client/syncclusterconnection.h
index 3907f7e50a0..02cc864bed4 100644
--- a/src/mongo/client/syncclusterconnection.h
+++ b/src/mongo/client/syncclusterconnection.h
@@ -51,7 +51,10 @@ namespace mongo {
          */
         SyncClusterConnection( const list<HostAndPort> &, double socketTimeout = 0);
         SyncClusterConnection( string commaSeparated, double socketTimeout = 0);
-        SyncClusterConnection( string a , string b , string c, double socketTimeout = 0 );
+        SyncClusterConnection( const std::string& a,
+                               const std::string& b,
+                               const std::string& c,
+                               double socketTimeout = 0 );
         ~SyncClusterConnection();
 
         /**
@@ -114,7 +117,7 @@ namespace mongo {
                                                 const BSONObj *fieldsToReturn, int queryOptions, int batchSize );
         int _lockType( const string& name );
         void _checkLast();
-        void _connect( string host );
+        void _connect( const std::string& host );
 
         string _address;
         vector<string> _connAddresses;