diff options
author | Xiangyu Yao <xiangyu.yao@mongodb.com> | 2019-02-12 15:53:24 -0500 |
---|---|---|
committer | Xiangyu Yao <xiangyu.yao@mongodb.com> | 2019-02-20 13:14:13 -0500 |
commit | acddc7f35f0373ccb2e8fe9d45f42304b2b74f95 (patch) | |
tree | 8064f3c96f8f265d088b101c1c3bb4dd247e9bce /src/mongo/db/catalog_raii.cpp | |
parent | 70aa69bfad6a66c7a00701403f1979ce77d654af (diff) | |
download | mongo-acddc7f35f0373ccb2e8fe9d45f42304b2b74f95.tar.gz |
SERVER-39425 Improve lock acquisition contract
Lock acquisition timeout should always throw exceptions rather than fail silently
Diffstat (limited to 'src/mongo/db/catalog_raii.cpp')
-rw-r--r-- | src/mongo/db/catalog_raii.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/mongo/db/catalog_raii.cpp b/src/mongo/db/catalog_raii.cpp index 651ba7d1ca6..a9a77a5e7e2 100644 --- a/src/mongo/db/catalog_raii.cpp +++ b/src/mongo/db/catalog_raii.cpp @@ -53,7 +53,6 @@ void uassertLockTimeout(std::string resourceName, LockMode lockMode, bool isLock AutoGetDb::AutoGetDb(OperationContext* opCtx, StringData dbName, LockMode mode, Date_t deadline) : _dbLock(opCtx, dbName, mode, deadline), _db([&] { - uassertLockTimeout(str::stream() << "database " << dbName, mode, _dbLock.isLocked()); auto databaseHolder = DatabaseHolder::get(opCtx); return databaseHolder->getDb(opCtx, dbName); }()) { @@ -76,9 +75,6 @@ AutoGetCollection::AutoGetCollection(OperationContext* opCtx, deadline), _resolvedNss(resolveNamespaceStringOrUUID(opCtx, nsOrUUID)) { _collLock.emplace(opCtx->lockState(), _resolvedNss.ns(), modeColl, deadline); - uassertLockTimeout( - str::stream() << "collection " << nsOrUUID.toString(), modeColl, _collLock->isLocked()); - // Wait for a configured amount of time after acquiring locks if the failpoint is enabled MONGO_FAIL_POINT_BLOCK(setAutoGetCollectionWait, customWait) { const BSONObj& data = customWait.getData(); |