SERVER-28534 Pass collection names around as NamespaceStrings more often

Before this patch 'ns' values were often passed around as std::string or
char* containing either a dbname (no '.'), a dbname with '.$cmd', or a fully qualified
collection name. Instead pass either plain 'dbName' value (as string) or a fully
qualified name using the actual NamespaceString type.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/mongo/db/cloner.cpp b/src/mongo/db/cloner.cpp
index 2fc1f6f0eaf..01d03fbc7bf 100644
--- a/src/mongo/db/cloner.cpp
+++ b/src/mongo/db/cloner.cpp
@@ -410,7 +410,7 @@ void Cloner::copyIndexes(OperationContext* opCtx,
     indexer.commit();
     if (opCtx->writesAreReplicated()) {
         const string targetSystemIndexesCollectionName = to_collection.getSystemIndexesCollection();
-        const char* createIndexNs = targetSystemIndexesCollectionName.c_str();
+        const NamespaceString createIndexNs{targetSystemIndexesCollectionName};
         for (auto&& infoObj : indexInfoObjs) {
             getGlobalServiceContext()->getOpObserver()->onCreateIndex(
                 opCtx, createIndexNs, infoObj, false);