SERVER-33816 convert "explain" command to single-parse model

    logAuthViolation
    depurify Command::enhancedRun
    lifetime issue with inner OpMsgRequest
    parse() return needs explicit unique_ptr ctor
    checkAuthForOperation elim
    move commandCanRunHere check from parse() to run()

1 files changed, 10 insertions, 3 deletions

diff --git a/src/mongo/db/commands.h b/src/mongo/db/commands.h
index 25ce1f056b0..7c3e7c63b0c 100644
--- a/src/mongo/db/commands.h
+++ b/src/mongo/db/commands.h
@@ -192,6 +192,13 @@ struct CommandHelpers {
      */
     static BSONObj runCommandDirectly(OperationContext* opCtx, const OpMsgRequest& request);
 
+    static void logAuthViolation(OperationContext* opCtx,
+                                 const Command* command,
+                                 const OpMsgRequest& request,
+                                 ErrorCodes::Error err);
+
+    static void uassertNoDocumentSequences(StringData commandName, const OpMsgRequest& request);
+
     static constexpr StringData kHelpFieldName = "help"_sd;
 };
 
@@ -447,7 +454,9 @@ private:
      */
     virtual bool enhancedRun(OperationContext* opCtx,
                              const OpMsgRequest& request,
-                             BSONObjBuilder& result) = 0;
+                             BSONObjBuilder& result) {
+        MONGO_UNREACHABLE;
+    }
 
     // Counters for how many times this command has been executed and failed
     Counter64 _commandsExecuted;
@@ -646,8 +655,6 @@ private:
      * Calls checkAuthForOperation.
      */
     Status checkAuthForRequest(OperationContext* opCtx, const OpMsgRequest& request) const final;
-
-    void uassertNoDocumentSequences(const OpMsgRequest& request) const;
 };
 
 /**