diff options
| author | Mathias Stearn <mathias@10gen.com> | 2018-05-02 17:32:34 -0400 |
|---|---|---|
| committer | Mathias Stearn <mathias@10gen.com> | 2018-05-08 14:57:37 -0400 |
| commit | db41862c5380ab33cf28db99726cdac252df0872 (patch) | |
| tree | a0fefd08ea9cc063456abe796390faaaa07ec272 /src/mongo/db/commands.h | |
| parent | 2d35461cb54e35afea223714fab1a184a9b381e2 (diff) | |
| download | mongo-db41862c5380ab33cf28db99726cdac252df0872.tar.gz | |
SERVER-34628 Really remove appendCommandStatus
All remaining callers are transitioned to some form of usassert. This was done
with an elaborate set of vim macros to make this tractable. Therefore it
should not be considered an example of the best way to write new code, just as
an improvement on what was there before. In particular, I couldn't easily
remove Status's that are named then only used once in uassertStatusOK, nor
could I convert the pattern of checking a StatusWith<T>'s getStatus() then
calling getValue() to just call uassertStatusOK(returnsStatusWith()).
Diffstat (limited to 'src/mongo/db/commands.h')
| -rw-r--r-- | src/mongo/db/commands.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/mongo/db/commands.h b/src/mongo/db/commands.h index 7b0c2e26a36..8d467747a28 100644 --- a/src/mongo/db/commands.h +++ b/src/mongo/db/commands.h @@ -108,9 +108,6 @@ struct CommandHelpers { */ static bool appendCommandStatusNoThrow(BSONObjBuilder& result, const Status& status); - // About to be deleted - static bool appendCommandStatus(BSONObjBuilder& result, const Status& status); - /** * If "ok" field is present in `reply`, uses its truthiness. * Otherwise, the absence of failure is considered success, `reply` is patched to indicate it. |