SERVER-28534 Pass collection names around as NamespaceStrings more often

Before this patch 'ns' values were often passed around as std::string or
char* containing either a dbname (no '.'), a dbname with '.$cmd', or a fully qualified
collection name. Instead pass either plain 'dbName' value (as string) or a fully
qualified name using the actual NamespaceString type.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/mongo/db/commands/create_indexes.cpp b/src/mongo/db/commands/create_indexes.cpp
index 93833f09b8e..9b821a15843 100644
--- a/src/mongo/db/commands/create_indexes.cpp
+++ b/src/mongo/db/commands/create_indexes.cpp
@@ -392,7 +392,7 @@ public:
             indexer.commit();
 
             for (auto&& infoObj : indexInfoObjs) {
-                std::string systemIndexes = ns.getSystemIndexesCollection();
+                NamespaceString systemIndexes{ns.getSystemIndexesCollection()};
                 getGlobalServiceContext()->getOpObserver()->onCreateIndex(
                     opCtx, systemIndexes, infoObj, false);
             }