summaryrefslogtreecommitdiff
path: root/src/mongo/db/commands/feature_compatibility_version.cpp
diff options
context:
space:
mode:
authorGrace Luong <grace.luong@mongodb.com>2020-07-15 15:52:07 +0000
committerEvergreen Agent <no-reply@evergreen.mongodb.com>2020-07-15 16:22:04 +0000
commit1c4dde30942b37f1fc0cfbaea688e66746e2406c (patch)
treeaa42c7fc6fa3c6ea619653870779c37c5c58cb4c /src/mongo/db/commands/feature_compatibility_version.cpp
parent35b5c8a5054456fb80b8ef3001557e6d16a84867 (diff)
downloadmongo-1c4dde30942b37f1fc0cfbaea688e66746e2406c.tar.gz
SERVER-49060: added comments for generic FCV constants and conditional checks
Diffstat (limited to 'src/mongo/db/commands/feature_compatibility_version.cpp')
-rw-r--r--src/mongo/db/commands/feature_compatibility_version.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/mongo/db/commands/feature_compatibility_version.cpp b/src/mongo/db/commands/feature_compatibility_version.cpp
index 5c96789c300..d7f3aef5d42 100644
--- a/src/mongo/db/commands/feature_compatibility_version.cpp
+++ b/src/mongo/db/commands/feature_compatibility_version.cpp
@@ -196,6 +196,7 @@ void FeatureCompatibilityVersion::_setVersion(
serverGlobalParams.featureCompatibility.setVersion(newVersion);
updateMinWireVersion();
+ // (Generic FCV reference): This FCV check should exist across LTS binary versions.
if (newVersion != ServerGlobalParams::FeatureCompatibility::kLastLTS) {
// Close all incoming connections from internal clients with binary versions lower than
// ours.
@@ -207,6 +208,7 @@ void FeatureCompatibilityVersion::_setVersion(
.dropConnections(transport::Session::kKeepOpen);
}
+ // (Generic FCV reference): This FCV check should exist across LTS binary versions.
if (newVersion != ServerGlobalParams::FeatureCompatibility::kLatest) {
if (MONGO_unlikely(hangBeforeAbortingRunningTransactionsOnFCVDowngrade.shouldFail())) {
LOGV2(20460,
@@ -227,6 +229,7 @@ void FeatureCompatibilityVersion::_setVersion(
// This can only happen in two scenarios:
// 1. Setting featureCompatibilityVersion from downgrading to fullyDowngraded.
// 2. Setting featureCompatibilityVersion from fullyDowngraded to upgrading.
+ // (Generic FCV reference): This FCV check should exist across LTS binary versions.
const auto shouldIncrementTopologyVersion =
newVersion == ServerGlobalParams::FeatureCompatibility::kLastLTS ||
newVersion == ServerGlobalParams::FeatureCompatibility::Version::kUpgradingFrom44To451;