diff options
author | Mathias Stearn <mathias@10gen.com> | 2014-05-13 12:47:59 -0400 |
---|---|---|
committer | Mathias Stearn <mathias@10gen.com> | 2014-05-14 14:14:44 -0400 |
commit | e3885bae0383148dc36274b04662235f978de483 (patch) | |
tree | 0432f3060a95c1e7ff95223c80c6602836ed5b53 /src/mongo/db/commands | |
parent | 6378da06b637dbf86f916274c8f0457d925af6a9 (diff) | |
download | mongo-e3885bae0383148dc36274b04662235f978de483.tar.gz |
SERVER-13641 Unify Command::newRun into run
This is the result of the following seds and a few manual fixups, including
removing the old run() and fixing the comments.
git grep -l '\<run(const' | xargs sed -si -e 's/\brun(const/newRun(TransactionExperiment* txn, const/'
git grep -l '\<run( const' | xargs sed -si -e 's/\brun( const/newRun(TransactionExperiment* txn, const/'
git grep -l '\<newRun(' | xargs sed -si -e 's/\bnewRun(/run(/'
Diffstat (limited to 'src/mongo/db/commands')
42 files changed, 73 insertions, 71 deletions
diff --git a/src/mongo/db/commands/apply_ops.cpp b/src/mongo/db/commands/apply_ops.cpp index b86d8716d08..285c83c7186 100644 --- a/src/mongo/db/commands/apply_ops.cpp +++ b/src/mongo/db/commands/apply_ops.cpp @@ -59,7 +59,7 @@ namespace mongo { // applyOps can do pretty much anything, so require all privileges. RoleGraph::generateUniversalPrivileges(out); } - virtual bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { if ( cmdObj.firstElement().type() != Array ) { errmsg = "ops has to be an array"; diff --git a/src/mongo/db/commands/auth_schema_upgrade_d.cpp b/src/mongo/db/commands/auth_schema_upgrade_d.cpp index d18fb04356c..bd27c4a68b1 100644 --- a/src/mongo/db/commands/auth_schema_upgrade_d.cpp +++ b/src/mongo/db/commands/auth_schema_upgrade_d.cpp @@ -113,6 +113,7 @@ namespace { class CmdAuthSchemaUpgradeD : public CmdAuthSchemaUpgrade { virtual bool run( + TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, diff --git a/src/mongo/db/commands/authentication_commands.cpp b/src/mongo/db/commands/authentication_commands.cpp index 532df4c015b..249fc0d93e4 100644 --- a/src/mongo/db/commands/authentication_commands.cpp +++ b/src/mongo/db/commands/authentication_commands.cpp @@ -99,7 +99,7 @@ namespace mongo { virtual void addRequiredPrivileges(const std::string& dbname, const BSONObj& cmdObj, std::vector<Privilege>* out) {} // No auth required - bool run(const string&, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string&, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { nonce64 n = getNextNonce(); stringstream ss; ss << hex << n; @@ -133,7 +133,7 @@ namespace mongo { } } - bool CmdAuthenticate::run(const string& dbname, + bool CmdAuthenticate::run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, @@ -351,7 +351,7 @@ namespace mongo { void help(stringstream& h) const { h << "de-authenticate"; } virtual bool isWriteCommandForConfigServer() const { return false; } CmdLogout() : Command("logout") {} - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, diff --git a/src/mongo/db/commands/authentication_commands.h b/src/mongo/db/commands/authentication_commands.h index 909857b3532..4c6a2420695 100644 --- a/src/mongo/db/commands/authentication_commands.h +++ b/src/mongo/db/commands/authentication_commands.h @@ -51,7 +51,7 @@ namespace mongo { virtual void redactForLogging(mutablebson::Document* cmdObj); CmdAuthenticate() : Command("authenticate") {} - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, diff --git a/src/mongo/db/commands/cleanup_orphaned_cmd.cpp b/src/mongo/db/commands/cleanup_orphaned_cmd.cpp index fcc81a00c59..fa9330d358e 100644 --- a/src/mongo/db/commands/cleanup_orphaned_cmd.cpp +++ b/src/mongo/db/commands/cleanup_orphaned_cmd.cpp @@ -179,7 +179,7 @@ namespace mongo { // Output static BSONField<BSONObj> stoppedAtKeyField; - bool newRun( TransactionExperiment* txn, + bool run( TransactionExperiment* txn, string const &db, BSONObj &cmdObj, int, diff --git a/src/mongo/db/commands/collection_to_capped.cpp b/src/mongo/db/commands/collection_to_capped.cpp index f1a375e6694..844ec2eec8e 100644 --- a/src/mongo/db/commands/collection_to_capped.cpp +++ b/src/mongo/db/commands/collection_to_capped.cpp @@ -142,7 +142,7 @@ namespace mongo { NamespaceString(dbname, collection)), targetActions)); } - bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { string from = jsobj.getStringField( "cloneCollectionAsCapped" ); string to = jsobj.getStringField( "toCollection" ); double size = jsobj.getField( "size" ).number(); @@ -196,7 +196,7 @@ namespace mongo { return std::vector<BSONObj>(); } - bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { // calls renamecollection which does a global lock, so we must too: // Lock::GlobalWrite globalWriteLock; diff --git a/src/mongo/db/commands/compact.cpp b/src/mongo/db/commands/compact.cpp index a469347d677..ec301bac843 100644 --- a/src/mongo/db/commands/compact.cpp +++ b/src/mongo/db/commands/compact.cpp @@ -83,7 +83,7 @@ namespace mongo { return IndexBuilder::killMatchingIndexBuilds(db->getCollection(ns), criteria); } - virtual bool newRun(TransactionExperiment* txn, const string& db, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + virtual bool run(TransactionExperiment* txn, const string& db, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { string coll = cmdObj.firstElement().valuestr(); if( coll.empty() || db.empty() ) { errmsg = "no collection name specified"; diff --git a/src/mongo/db/commands/connection_status.cpp b/src/mongo/db/commands/connection_status.cpp index 56172be081c..1f9e9b7685e 100644 --- a/src/mongo/db/commands/connection_status.cpp +++ b/src/mongo/db/commands/connection_status.cpp @@ -46,7 +46,7 @@ namespace mongo { h << "Returns connection-specific information such as logged-in users"; } - bool run(const string&, BSONObj& cmdObj, int, string& errmsg, + bool run(TransactionExperiment* txn, const string&, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { AuthorizationSession* authSession = ClientBasic::getCurrent()->getAuthorizationSession(); diff --git a/src/mongo/db/commands/create_indexes.cpp b/src/mongo/db/commands/create_indexes.cpp index 06b0b6e20b7..76a3c731637 100644 --- a/src/mongo/db/commands/create_indexes.cpp +++ b/src/mongo/db/commands/create_indexes.cpp @@ -70,7 +70,7 @@ namespace mongo { return b.obj(); } - virtual bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, BSONObjBuilder& result, bool fromRepl = false ) { diff --git a/src/mongo/db/commands/dbhash.cpp b/src/mongo/db/commands/dbhash.cpp index af33930f901..802a99cba5f 100644 --- a/src/mongo/db/commands/dbhash.cpp +++ b/src/mongo/db/commands/dbhash.cpp @@ -125,7 +125,7 @@ namespace mongo { return hash; } - bool DBHashCmd::run(const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { + bool DBHashCmd::run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { Timer timer; set<string> desiredCollections; diff --git a/src/mongo/db/commands/dbhash.h b/src/mongo/db/commands/dbhash.h index 5d74a2ae359..cb0cbdefa1c 100644 --- a/src/mongo/db/commands/dbhash.h +++ b/src/mongo/db/commands/dbhash.h @@ -46,7 +46,7 @@ namespace mongo { const BSONObj& cmdObj, std::vector<Privilege>* out); - virtual bool run(const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool); + virtual bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool); void wipeCacheForCollection( const StringData& ns ); diff --git a/src/mongo/db/commands/distinct.cpp b/src/mongo/db/commands/distinct.cpp index 3bf8152fee3..5b6888154d6 100644 --- a/src/mongo/db/commands/distinct.cpp +++ b/src/mongo/db/commands/distinct.cpp @@ -68,7 +68,7 @@ namespace mongo { help << "{ distinct : 'collection name' , key : 'a.b' , query : {} }"; } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { Timer t; diff --git a/src/mongo/db/commands/drop_indexes.cpp b/src/mongo/db/commands/drop_indexes.cpp index ea60d797f69..ac9deff5ded 100644 --- a/src/mongo/db/commands/drop_indexes.cpp +++ b/src/mongo/db/commands/drop_indexes.cpp @@ -92,7 +92,7 @@ namespace mongo { } CmdDropIndexes() : Command("dropIndexes", false, "deleteIndexes") { } - bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& anObjBuilder, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& anObjBuilder, bool fromRepl) { Lock::DBWrite dbXLock(dbname); bool ok = wrappedRun(txn, dbname, jsobj, errmsg, anObjBuilder); if (ok && !fromRepl) @@ -212,7 +212,7 @@ namespace mongo { return IndexBuilder::killMatchingIndexBuilds(db->getCollection(ns), criteria); } - bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool /*fromRepl*/) { + bool run(TransactionExperiment* txn, const string& dbname , BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool /*fromRepl*/) { static DBDirectClient db; BSONElement e = jsobj.firstElement(); diff --git a/src/mongo/db/commands/fail_point_cmd.cpp b/src/mongo/db/commands/fail_point_cmd.cpp index a36160cb5bd..bcb46cc4332 100644 --- a/src/mongo/db/commands/fail_point_cmd.cpp +++ b/src/mongo/db/commands/fail_point_cmd.cpp @@ -81,7 +81,7 @@ namespace mongo { h << "modifies the settings of a fail point"; } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, diff --git a/src/mongo/db/commands/find_and_modify.cpp b/src/mongo/db/commands/find_and_modify.cpp index 98aab888860..47043005667 100644 --- a/src/mongo/db/commands/find_and_modify.cpp +++ b/src/mongo/db/commands/find_and_modify.cpp @@ -297,7 +297,7 @@ namespace mongo { return true; } - virtual bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int x, string& errmsg, BSONObjBuilder& result, bool y) { + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int x, string& errmsg, BSONObjBuilder& result, bool y) { DBDirectClient db(txn); if (cmdObj["sort"].eoo()) { diff --git a/src/mongo/db/commands/fsync.cpp b/src/mongo/db/commands/fsync.cpp index c304e1ae46a..8837c91c05c 100644 --- a/src/mongo/db/commands/fsync.cpp +++ b/src/mongo/db/commands/fsync.cpp @@ -92,7 +92,7 @@ namespace mongo { actions.addAction(ActionType::fsync); out->push_back(Privilege(ResourcePattern::forClusterResource(), actions)); } - virtual bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { if (Lock::isLocked()) { errmsg = "fsync: Cannot execute fsync command from contexts that hold a data lock"; diff --git a/src/mongo/db/commands/geonear.cpp b/src/mongo/db/commands/geonear.cpp index d7c6f5a4cd5..9a6582fede5 100644 --- a/src/mongo/db/commands/geonear.cpp +++ b/src/mongo/db/commands/geonear.cpp @@ -68,7 +68,7 @@ namespace mongo { out->push_back(Privilege(parseResourcePattern(dbname, cmdObj), actions)); } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { const string ns = dbname + "." + cmdObj.firstElement().valuestr(); if (!cmdObj["start"].eoo()) { diff --git a/src/mongo/db/commands/get_last_error.cpp b/src/mongo/db/commands/get_last_error.cpp index 2775520ac94..dde7a40e84f 100644 --- a/src/mongo/db/commands/get_last_error.cpp +++ b/src/mongo/db/commands/get_last_error.cpp @@ -57,7 +57,7 @@ namespace mongo { help << "reset error state (used with getpreverror)"; } CmdResetError() : Command("resetError", false, "reseterror") {} - bool run(const string& db, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& db, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { LastError *le = lastError.get(); verify( le ); le->reset(); @@ -91,7 +91,7 @@ namespace mongo { << " { wtimeout:m} - timeout for w in m milliseconds"; } - bool run( const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, @@ -262,7 +262,7 @@ namespace mongo { const BSONObj& cmdObj, std::vector<Privilege>* out) {} // No auth required CmdGetPrevError() : Command("getPrevError", false, "getpreverror") {} - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { LastError *le = lastError.disableForCommand(); le->appendSelf( result ); if ( le->valid ) diff --git a/src/mongo/db/commands/group.cpp b/src/mongo/db/commands/group.cpp index c6fd5c0f7bb..8a1608f7e71 100644 --- a/src/mongo/db/commands/group.cpp +++ b/src/mongo/db/commands/group.cpp @@ -202,7 +202,7 @@ namespace mongo { return true; } - bool run(const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& jsobj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { if ( !globalScriptEngine ) { errmsg = "server-side JavaScript execution is disabled"; diff --git a/src/mongo/db/commands/hashcmd.cpp b/src/mongo/db/commands/hashcmd.cpp index 3e8c29bc3a4..cff86b33e42 100644 --- a/src/mongo/db/commands/hashcmd.cpp +++ b/src/mongo/db/commands/hashcmd.cpp @@ -72,7 +72,7 @@ namespace mongo { *> "out" : NumberLong(6271151123721111923), *> "ok" : 1 } **/ - bool run( const string& db, + bool run(TransactionExperiment* txn, const string& db, BSONObj& cmdObj, int options, string& errmsg, BSONObjBuilder& result, diff --git a/src/mongo/db/commands/index_filter_commands.cpp b/src/mongo/db/commands/index_filter_commands.cpp index 9f006ad7ac7..b4d9d6c93e4 100644 --- a/src/mongo/db/commands/index_filter_commands.cpp +++ b/src/mongo/db/commands/index_filter_commands.cpp @@ -120,7 +120,7 @@ namespace mongo { : Command(name), helpText(helpText) { } - bool IndexFilterCommand::run(const string& dbname, BSONObj& cmdObj, int options, + bool IndexFilterCommand::run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, BSONObjBuilder& result, bool fromRepl) { string ns = parseNs(dbname, cmdObj); diff --git a/src/mongo/db/commands/index_filter_commands.h b/src/mongo/db/commands/index_filter_commands.h index badb55f185d..ac372668769 100644 --- a/src/mongo/db/commands/index_filter_commands.h +++ b/src/mongo/db/commands/index_filter_commands.h @@ -63,7 +63,7 @@ namespace mongo { * implement plan cache command functionality. */ - bool run(const std::string& dbname, BSONObj& cmdObj, int options, + bool run(TransactionExperiment* txn, const std::string& dbname, BSONObj& cmdObj, int options, std::string& errmsg, BSONObjBuilder& result, bool fromRepl); virtual bool isWriteCommandForConfigServer() const; diff --git a/src/mongo/db/commands/index_stats.cpp b/src/mongo/db/commands/index_stats.cpp index 196f2c0d4fa..1b0c69e42b2 100644 --- a/src/mongo/db/commands/index_stats.cpp +++ b/src/mongo/db/commands/index_stats.cpp @@ -492,7 +492,7 @@ namespace mongo { out->push_back(Privilege(parseResourcePattern(dbname, cmdObj), actions)); } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { NamespaceString nss( dbname, cmdObj.firstElement().valuestrsafe() ); diff --git a/src/mongo/db/commands/isself.cpp b/src/mongo/db/commands/isself.cpp index 1ecaedb5463..8f5fc57210d 100644 --- a/src/mongo/db/commands/isself.cpp +++ b/src/mongo/db/commands/isself.cpp @@ -184,7 +184,7 @@ namespace mongo { virtual void addRequiredPrivileges(const std::string& dbname, const BSONObj& cmdObj, std::vector<Privilege>* out) {} // No auth required - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { init(); result.append( "id" , _id ); return true; diff --git a/src/mongo/db/commands/merge_chunks_cmd.cpp b/src/mongo/db/commands/merge_chunks_cmd.cpp index 189608f4026..d7c39a6ecd5 100644 --- a/src/mongo/db/commands/merge_chunks_cmd.cpp +++ b/src/mongo/db/commands/merge_chunks_cmd.cpp @@ -80,7 +80,7 @@ namespace mongo { static BSONField<string> shardNameField; static BSONField<string> configField; - bool run( const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, diff --git a/src/mongo/db/commands/mr.cpp b/src/mongo/db/commands/mr.cpp index 7a540a8a3ef..543cae19cf0 100644 --- a/src/mongo/db/commands/mr.cpp +++ b/src/mongo/db/commands/mr.cpp @@ -1208,7 +1208,7 @@ namespace mongo { addPrivilegesRequiredForMapReduce(this, dbname, cmdObj, out); } - bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& cmd, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmd, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { Timer t; Client& client = cc(); CurOp * op = client.curop(); @@ -1446,7 +1446,7 @@ namespace mongo { actions.addAction(ActionType::internal); out->push_back(Privilege(ResourcePattern::forClusterResource(), actions)); } - bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { + bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { ShardedConnectionInfo::addHook(); // legacy name string shardedOutputCollection = cmdObj["shardedOutputCollection"].valuestrsafe(); diff --git a/src/mongo/db/commands/oplog_note.cpp b/src/mongo/db/commands/oplog_note.cpp index 895bf8d21d7..bd5a67fc098 100644 --- a/src/mongo/db/commands/oplog_note.cpp +++ b/src/mongo/db/commands/oplog_note.cpp @@ -56,7 +56,7 @@ namespace mongo { } return Status::OK(); } - virtual bool run(const string& dbname, + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, diff --git a/src/mongo/db/commands/parallel_collection_scan.cpp b/src/mongo/db/commands/parallel_collection_scan.cpp index 34459ffaf18..58a530184b5 100644 --- a/src/mongo/db/commands/parallel_collection_scan.cpp +++ b/src/mongo/db/commands/parallel_collection_scan.cpp @@ -159,7 +159,7 @@ namespace mongo { return Status(ErrorCodes::Unauthorized, "Unauthorized"); } - virtual bool run( const string& dbname, BSONObj& cmdObj, int options, + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, BSONObjBuilder& result, bool fromRepl = false ) { diff --git a/src/mongo/db/commands/parameters.cpp b/src/mongo/db/commands/parameters.cpp index 2c1203d04ff..af9ad7c822f 100644 --- a/src/mongo/db/commands/parameters.cpp +++ b/src/mongo/db/commands/parameters.cpp @@ -72,7 +72,7 @@ namespace mongo { appendParameterNames( help ); help << "{ getParameter:'*' } to get everything\n"; } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { bool all = *cmdObj.firstElement().valuestrsafe() == '*'; int before = result.len(); @@ -126,7 +126,7 @@ namespace mongo { help << "{ setParameter:1, <param>:<value> }\n"; appendParameterNames( help ); } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { int s = 0; bool found = false; diff --git a/src/mongo/db/commands/pipeline_command.cpp b/src/mongo/db/commands/pipeline_command.cpp index 7d48d1b40db..34652d66daf 100644 --- a/src/mongo/db/commands/pipeline_command.cpp +++ b/src/mongo/db/commands/pipeline_command.cpp @@ -273,7 +273,7 @@ namespace { Pipeline::addRequiredPrivileges(this, dbname, cmdObj, out); } - virtual bool run(const string &db, BSONObj &cmdObj, int options, string &errmsg, + virtual bool run(TransactionExperiment* txn, const string &db, BSONObj &cmdObj, int options, string &errmsg, BSONObjBuilder &result, bool fromRepl) { string ns = parseNs(db, cmdObj); diff --git a/src/mongo/db/commands/plan_cache_commands.cpp b/src/mongo/db/commands/plan_cache_commands.cpp index 6287a6ab77a..a58dcb78851 100644 --- a/src/mongo/db/commands/plan_cache_commands.cpp +++ b/src/mongo/db/commands/plan_cache_commands.cpp @@ -114,7 +114,7 @@ namespace mongo { helpText(helpText), actionType(actionType) { } - bool PlanCacheCommand::run(const string& dbname, BSONObj& cmdObj, int options, + bool PlanCacheCommand::run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, BSONObjBuilder& result, bool fromRepl) { string ns = parseNs(dbname, cmdObj); diff --git a/src/mongo/db/commands/plan_cache_commands.h b/src/mongo/db/commands/plan_cache_commands.h index 59c9dc78d20..1c1de2da9f5 100644 --- a/src/mongo/db/commands/plan_cache_commands.h +++ b/src/mongo/db/commands/plan_cache_commands.h @@ -58,7 +58,7 @@ namespace mongo { * implement plan cache command functionality. */ - bool run(const std::string& dbname, BSONObj& cmdObj, int options, + bool run(TransactionExperiment* txn, const std::string& dbname, BSONObj& cmdObj, int options, std::string& errmsg, BSONObjBuilder& result, bool fromRepl); virtual bool isWriteCommandForConfigServer() const; diff --git a/src/mongo/db/commands/rename_collection.cpp b/src/mongo/db/commands/rename_collection.cpp index 07bf511141b..196d28ae735 100644 --- a/src/mongo/db/commands/rename_collection.cpp +++ b/src/mongo/db/commands/rename_collection.cpp @@ -91,7 +91,7 @@ namespace mongo { IndexBuilder::restoreIndexes( indexesInProg ); } - virtual bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { Lock::GlobalWrite globalWriteLock; bool ok = wrappedRun(txn, dbname, cmdObj, errmsg, result, fromRepl); if (ok && !fromRepl) diff --git a/src/mongo/db/commands/server_status.cpp b/src/mongo/db/commands/server_status.cpp index 181d172547a..8a6923c8772 100644 --- a/src/mongo/db/commands/server_status.cpp +++ b/src/mongo/db/commands/server_status.cpp @@ -71,7 +71,7 @@ namespace mongo { actions.addAction(ActionType::serverStatus); out->push_back(Privilege(ResourcePattern::forClusterResource(), actions)); } - bool run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { _runCalled = true; diff --git a/src/mongo/db/commands/shutdown.h b/src/mongo/db/commands/shutdown.h index 9311ac70f9b..7120da6fbad 100644 --- a/src/mongo/db/commands/shutdown.h +++ b/src/mongo/db/commands/shutdown.h @@ -49,7 +49,7 @@ namespace mongo { virtual bool isWriteCommandForConfigServer() const { return false; } virtual void help( stringstream& help ) const; CmdShutdown() : Command("shutdown") {} - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, diff --git a/src/mongo/db/commands/storage_details.cpp b/src/mongo/db/commands/storage_details.cpp index 09af6984b18..1121a3e22dd 100644 --- a/src/mongo/db/commands/storage_details.cpp +++ b/src/mongo/db/commands/storage_details.cpp @@ -323,7 +323,7 @@ namespace { /** * Entry point, parses command parameters and invokes runInternal. */ - bool run(const string& dbname , BSONObj& cmdObj, int, string& errmsg, + bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl); }; @@ -756,7 +756,7 @@ namespace { static const char* USE_ANALYZE_STR = "use {analyze: 'diskStorage' | 'pagesInRAM'}"; - bool StorageDetailsCmd::run(const string& dbname, BSONObj& cmdObj, int, string& errmsg, + bool StorageDetailsCmd::run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { // { analyze: subcommand } diff --git a/src/mongo/db/commands/test_commands.cpp b/src/mongo/db/commands/test_commands.cpp index 428298868b9..3abd64cd40d 100644 --- a/src/mongo/db/commands/test_commands.cpp +++ b/src/mongo/db/commands/test_commands.cpp @@ -55,7 +55,7 @@ namespace mongo { virtual void help( stringstream &help ) const { help << "internal. for testing only."; } - virtual bool newRun(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { string coll = cmdObj[ "godinsert" ].valuestrsafe(); log() << "test only command godinsert invoked coll:" << coll << endl; uassert( 13049, "godinsert must specify a collection", !coll.empty() ); @@ -93,7 +93,7 @@ namespace mongo { const BSONObj& cmdObj, std::vector<Privilege>* out) {} CmdSleep() : Command("sleep") { } - bool run(const string& ns, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + bool run(TransactionExperiment* txn, const string& ns, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { log() << "test only command sleep invoked" << endl; long long millis = 10 * 1000; @@ -133,7 +133,7 @@ namespace mongo { virtual void addRequiredPrivileges(const std::string& dbname, const BSONObj& cmdObj, std::vector<Privilege>* out) {} - virtual bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { + virtual bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool) { string coll = cmdObj[ "captrunc" ].valuestrsafe(); uassert( 13416, "captrunc must specify a collection", !coll.empty() ); NamespaceString nss( dbname, coll ); @@ -180,7 +180,7 @@ namespace mongo { return IndexBuilder::killMatchingIndexBuilds(db->getCollection(ns), criteria); } - virtual bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { + virtual bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) { string coll = cmdObj[ "emptycapped" ].valuestrsafe(); uassert( 13428, "emptycapped must specify a collection", !coll.empty() ); NamespaceString nss( dbname, coll ); diff --git a/src/mongo/db/commands/touch.cpp b/src/mongo/db/commands/touch.cpp index 2011758f042..4039d386ef4 100644 --- a/src/mongo/db/commands/touch.cpp +++ b/src/mongo/db/commands/touch.cpp @@ -77,7 +77,7 @@ namespace mongo { } TouchCmd() : Command("touch") { } - virtual bool newRun(TransactionExperiment* txn, + virtual bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int, diff --git a/src/mongo/db/commands/user_management_commands.cpp b/src/mongo/db/commands/user_management_commands.cpp index 79de0fe563d..b6e6cc65545 100644 --- a/src/mongo/db/commands/user_management_commands.cpp +++ b/src/mongo/db/commands/user_management_commands.cpp @@ -341,7 +341,7 @@ namespace mongo { return checkAuthorizedToGrantRoles(authzSession, args.roles); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -527,7 +527,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -651,7 +651,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -737,7 +737,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -819,7 +819,7 @@ namespace mongo { return checkAuthorizedToGrantRoles(authzSession, roles); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -917,7 +917,7 @@ namespace mongo { return checkAuthorizedToRevokeRoles(authzSession, roles); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1033,7 +1033,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1175,7 +1175,7 @@ namespace mongo { return checkAuthorizedToGrantPrivileges(authzSession, args.privileges); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1321,7 +1321,7 @@ namespace mongo { return checkAuthorizedToGrantPrivileges(authzSession, args.privileges); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1442,7 +1442,7 @@ namespace mongo { return checkAuthorizedToGrantPrivileges(authzSession, privileges); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1578,7 +1578,7 @@ namespace mongo { return checkAuthorizedToRevokePrivileges(authzSession, privileges); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1715,7 +1715,7 @@ namespace mongo { return checkAuthorizedToGrantRoles(authzSession, roles); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1834,7 +1834,7 @@ namespace mongo { return checkAuthorizedToRevokeRoles(authzSession, roles); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -1953,7 +1953,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -2121,7 +2121,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -2276,7 +2276,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -2356,7 +2356,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -2400,7 +2400,8 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, + const string& dbname, BSONObj& cmdObj, int options, string& errmsg, @@ -2808,7 +2809,7 @@ namespace mongo { return Status::OK(); } - bool run(const string& dbname, + bool run(TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, int options, string& errmsg, diff --git a/src/mongo/db/commands/validate.cpp b/src/mongo/db/commands/validate.cpp index 3fba9dd4b00..56f5382548c 100644 --- a/src/mongo/db/commands/validate.cpp +++ b/src/mongo/db/commands/validate.cpp @@ -59,7 +59,7 @@ namespace mongo { } //{ validate: "collectionnamewithoutthedbpart" [, scandata: <bool>] [, full: <bool> } */ - bool newRun(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { + bool run(TransactionExperiment* txn, const string& dbname , BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl ) { string ns = dbname + "." + cmdObj.firstElement().valuestrsafe(); NamespaceString ns_string(ns); diff --git a/src/mongo/db/commands/write_commands/write_commands.cpp b/src/mongo/db/commands/write_commands/write_commands.cpp index bcc297cf4b6..dcdd527f19f 100644 --- a/src/mongo/db/commands/write_commands/write_commands.cpp +++ b/src/mongo/db/commands/write_commands/write_commands.cpp @@ -102,7 +102,7 @@ namespace mongo { // Write commands are counted towards their corresponding opcounters, not command opcounters. bool WriteCmd::shouldAffectCommandCounter() const { return false; } - bool WriteCmd::newRun(TransactionExperiment* txn, + bool WriteCmd::run(TransactionExperiment* txn, const string& dbName, BSONObj& cmdObj, int options, diff --git a/src/mongo/db/commands/write_commands/write_commands.h b/src/mongo/db/commands/write_commands/write_commands.h index c94c505d5b5..9a8d96b5ac2 100644 --- a/src/mongo/db/commands/write_commands/write_commands.h +++ b/src/mongo/db/commands/write_commands/write_commands.h @@ -72,7 +72,7 @@ namespace mongo { virtual bool shouldAffectCommandCounter() const; // Write command entry point. - virtual bool newRun( + virtual bool run( TransactionExperiment* txn, const string& dbname, BSONObj& cmdObj, |