SERVER-7332 Censor command line explicitly, change CmdLine::store to take a vector of strings.

This patch separates the process of censoring the process argv array (affecting the output of ps on
linux) from the process of parsing the command line.  It then changes CmdLine::store to take a
vector of strings, instead of a mutable char**, for later use in the init system's command line
processing role.

Unit tests for the new censoring code, which is more throrough than the old, are included, and the
"command" to get the contents of the command line is moved to dbcommands_generic, to make linking
cmdline.cpp into unit tests easier.

1 files changed, 16 insertions, 0 deletions

diff --git a/src/mongo/db/dbcommands_generic.cpp b/src/mongo/db/dbcommands_generic.cpp
index ff128dbd1ff..aaba9d365a9 100644
--- a/src/mongo/db/dbcommands_generic.cpp
+++ b/src/mongo/db/dbcommands_generic.cpp
@@ -476,4 +476,20 @@ namespace mongo {
 
     } getLogCmd;
 
+    class CmdGetCmdLineOpts : Command {
+    public:
+        CmdGetCmdLineOpts(): Command("getCmdLineOpts") {}
+        void help(stringstream& h) const { h << "get argv"; }
+        virtual LockType locktype() const { return NONE; }
+        virtual bool adminOnly() const { return true; }
+        virtual bool slaveOk() const { return true; }
+
+        virtual bool run(const string&, BSONObj& cmdObj, int, string& errmsg, BSONObjBuilder& result, bool fromRepl) {
+            result.append("argv", CmdLine::getArgvArray());
+            result.append("parsed", CmdLine::getParsedOpts());
+            return true;
+        }
+
+    } cmdGetCmdLineOpts;
+
 }