diff options
| author | Benety Goh <benety@mongodb.com> | 2020-02-14 19:56:47 -0500 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2020-02-15 01:09:40 +0000 |
| commit | ee466720d56ceb1e32abe2636b26cb0d2facd8d9 (patch) | |
| tree | a89fc3cdff1d2f9468dd5fda126a5c3688a57bf3 /src/mongo/db/index_builds_coordinator.h | |
| parent | 3c4dc6da82c595834719ac00f6fdfa22deffcb83 (diff) | |
| download | mongo-ee466720d56ceb1e32abe2636b26cb0d2facd8d9.tar.gz | |
SERVER-45885 remove redundant NamespaceStringOrUUID parameter from IndexBuildsCoordinator internal functions
This information can be derived from ReplIndexBuildState.
Diffstat (limited to 'src/mongo/db/index_builds_coordinator.h')
| -rw-r--r-- | src/mongo/db/index_builds_coordinator.h | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/src/mongo/db/index_builds_coordinator.h b/src/mongo/db/index_builds_coordinator.h index 69f34bdc924..0aa5c17a9b4 100644 --- a/src/mongo/db/index_builds_coordinator.h +++ b/src/mongo/db/index_builds_coordinator.h @@ -541,7 +541,6 @@ protected: * Modularizes the _indexBuildsManager calls part of _runIndexBuildInner. Throws on error. */ void _buildIndex(OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, std::shared_ptr<ReplIndexBuildState> replState, const IndexBuildOptions& indexBuildOptions, boost::optional<Lock::CollectionLock>* collLock); @@ -552,7 +551,6 @@ protected: * createIndexes oplog entry. */ void _buildIndexSinglePhase(OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, std::shared_ptr<ReplIndexBuildState> replState, const IndexBuildOptions& indexBuildOptions, boost::optional<Lock::CollectionLock>* collLock); @@ -563,7 +561,6 @@ protected: * commitIndexBuild oplog entries, respectively. */ void _buildIndexTwoPhase(OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, std::shared_ptr<ReplIndexBuildState> replState, const IndexBuildOptions& indexBuildOptions, boost::optional<Lock::CollectionLock>* collLock); @@ -573,20 +570,14 @@ protected: */ void _scanCollectionAndInsertKeysIntoSorter( OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, std::shared_ptr<ReplIndexBuildState> replState, boost::optional<Lock::CollectionLock>* exclusiveCollectionLock); /** * Second phase is extracting the sorted keys and writing them into the new index table. - * On completion, this function returns the namespace of the collection, which may have changed - * after the previous phase. The namespace is used in two phase index builds to determine the - * current replication state in _waitForCommitOrAbort(). */ - NamespaceString _insertKeysFromSideTablesWithoutBlockingWrites( - OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, - std::shared_ptr<ReplIndexBuildState> replState); + void _insertKeysFromSideTablesWithoutBlockingWrites( + OperationContext* opCtx, std::shared_ptr<ReplIndexBuildState> replState); /** * Waits for commit or abort signal from primary. @@ -613,7 +604,6 @@ protected: */ void _insertKeysFromSideTablesAndCommit( OperationContext* opCtx, - const NamespaceStringOrUUID& dbAndUUID, std::shared_ptr<ReplIndexBuildState> replState, const IndexBuildOptions& indexBuildOptions, boost::optional<Lock::CollectionLock>* exclusiveCollectionLock, |