SERVER-32198 Change the namespaces stored as StringData to NamespaceString

This avoids having to cast them to NamespaceString for passing to
functions or to std::string for comparisons.

1 files changed, 11 insertions, 12 deletions

diff --git a/src/mongo/db/namespace_string.h b/src/mongo/db/namespace_string.h
index a5e9f15bd39..8e5eaa5e460 100644
--- a/src/mongo/db/namespace_string.h
+++ b/src/mongo/db/namespace_string.h
@@ -60,18 +60,6 @@ public:
     // Name for the system views collection
     static constexpr StringData kSystemDotViewsCollectionName = "system.views"_sd;
 
-    // Name for a shard's collections metadata collection, each document of which indicates the
-    // state of a specific collection.
-    static constexpr StringData kShardConfigCollectionsCollectionName =
-        "config.cache.collections"_sd;
-
-    // Name for a shard's databases metadata collection, each document of which indicates the
-    // state of a specific database.
-    static constexpr StringData kShardConfigDatabasesCollectionName = "config.cache.databases"_sd;
-
-    // Name for causal consistency's key collection.
-    static constexpr StringData kSystemKeysCollectionName = "admin.system.keys"_sd;
-
     // Namespace for storing configuration data, which needs to be replicated if the server is
     // running as a replica set. Documents in this collection should represent some configuration
     // state of the server, which needs to be recovered/consulted at startup. Each document in this
@@ -82,6 +70,17 @@ public:
     // Namespace for storing the transaction information for each session
     static const NamespaceString kSessionTransactionsTableNamespace;
 
+    // Name for a shard's collections metadata collection, each document of which indicates the
+    // state of a specific collection
+    static const NamespaceString kShardConfigCollectionsNamespace;
+
+    // Name for a shard's databases metadata collection, each document of which indicates the state
+    // of a specific database
+    static const NamespaceString kShardConfigDatabasesNamespace;
+
+    // Name for causal consistency's key collection.
+    static const NamespaceString kSystemKeysNamespace;
+
     // Namespace of the the oplog collection.
     static const NamespaceString kRsOplogNamespace;