diff options
author | Evan Nixon <evan.nixon@10gen.com> | 2019-04-11 20:17:55 -0700 |
---|---|---|
committer | Evan Nixon <evan.nixon@10gen.com> | 2019-04-11 20:17:55 -0700 |
commit | 5c78378563bf9b665e6ba829c0e5429e520f12e6 (patch) | |
tree | 6d523d85100dfa3a4b19d593b3fa480b6ff6c23e /src/mongo/db/pipeline | |
parent | 0b8c52e60eacd87bb0fcdb30da54a64f9df85ff0 (diff) | |
download | mongo-5c78378563bf9b665e6ba829c0e5429e520f12e6.tar.gz |
SERVER-39396 Move stub mongo process interface with mocked lookupSingleDocument to shared place
Diffstat (limited to 'src/mongo/db/pipeline')
4 files changed, 174 insertions, 74 deletions
diff --git a/src/mongo/db/pipeline/SConscript b/src/mongo/db/pipeline/SConscript index d8cd37fe5a3..37c2eee8a0d 100644 --- a/src/mongo/db/pipeline/SConscript +++ b/src/mongo/db/pipeline/SConscript @@ -188,6 +188,7 @@ env.Library( target='document_source_mock', source=[ 'document_source_mock.cpp', + 'stub_mongo_process_interface_lookup_single_document.cpp', ], LIBDEPS=[ '$BUILD_DIR/mongo/db/query/query_test_service_context', diff --git a/src/mongo/db/pipeline/document_source_lookup_change_post_image_test.cpp b/src/mongo/db/pipeline/document_source_lookup_change_post_image_test.cpp index 723ddc186ba..32ce6ebce8f 100644 --- a/src/mongo/db/pipeline/document_source_lookup_change_post_image_test.cpp +++ b/src/mongo/db/pipeline/document_source_lookup_change_post_image_test.cpp @@ -43,7 +43,7 @@ #include "mongo/db/pipeline/document_source_mock.h" #include "mongo/db/pipeline/document_value_test_util.h" #include "mongo/db/pipeline/field_path.h" -#include "mongo/db/pipeline/stub_mongo_process_interface.h" +#include "mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.h" #include "mongo/db/pipeline/value.h" namespace mongo { @@ -52,6 +52,8 @@ using boost::intrusive_ptr; using std::deque; using std::vector; +using MockMongoInterface = StubMongoProcessInterfaceLookupSingleDocument; + // This provides access to getExpCtx(), but we'll use a different name for this test suite. class DocumentSourceLookupChangePostImageTest : public AggregationContextFixture { public: @@ -76,79 +78,6 @@ public: } }; -/** - * A mock MongoProcessInterface which allows mocking a foreign pipeline. - */ -class MockMongoInterface final : public StubMongoProcessInterface { -public: - MockMongoInterface(deque<DocumentSource::GetNextResult> mockResults) - : _mockResults(std::move(mockResults)) {} - - bool isSharded(OperationContext* opCtx, const NamespaceString& nss) final { - return false; - } - - std::unique_ptr<Pipeline, PipelineDeleter> makePipeline( - const std::vector<BSONObj>& rawPipeline, - const boost::intrusive_ptr<ExpressionContext>& expCtx, - const MakePipelineOptions opts = MakePipelineOptions{}) final { - auto pipeline = uassertStatusOK(Pipeline::parse(rawPipeline, expCtx)); - - if (opts.optimize) { - pipeline->optimizePipeline(); - } - - if (opts.attachCursorSource) { - pipeline = attachCursorSourceToPipeline(expCtx, pipeline.release()); - } - - return pipeline; - } - - std::unique_ptr<Pipeline, PipelineDeleter> attachCursorSourceToPipeline( - const boost::intrusive_ptr<ExpressionContext>& expCtx, Pipeline* ownedPipeline) final { - std::unique_ptr<Pipeline, PipelineDeleter> pipeline(ownedPipeline, - PipelineDeleter(expCtx->opCtx)); - pipeline->addInitialSource(DocumentSourceMock::create(_mockResults)); - return pipeline; - } - - boost::optional<Document> lookupSingleDocument( - const boost::intrusive_ptr<ExpressionContext>& expCtx, - const NamespaceString& nss, - UUID collectionUUID, - const Document& documentKey, - boost::optional<BSONObj> readConcern, - bool allowSpeculativeMajorityRead) { - // The namespace 'nss' may be different than the namespace on the ExpressionContext in the - // case of a change stream on a whole database so we need to make a copy of the - // ExpressionContext with the new namespace. - auto foreignExpCtx = expCtx->copyWith(nss, collectionUUID, boost::none); - std::unique_ptr<Pipeline, PipelineDeleter> pipeline; - try { - pipeline = makePipeline({BSON("$match" << documentKey)}, foreignExpCtx); - } catch (ExceptionFor<ErrorCodes::NamespaceNotFound>&) { - return boost::none; - } - - auto lookedUpDocument = pipeline->getNext(); - if (auto next = pipeline->getNext()) { - uasserted(ErrorCodes::TooManyMatchingDocuments, - str::stream() << "found more than one document matching " - << documentKey.toString() - << " [" - << lookedUpDocument->toString() - << ", " - << next->toString() - << "]"); - } - return lookedUpDocument; - } - -private: - deque<DocumentSource::GetNextResult> _mockResults; -}; - TEST_F(DocumentSourceLookupChangePostImageTest, ShouldErrorIfMissingDocumentKeyOnUpdate) { auto expCtx = getExpCtx(); diff --git a/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.cpp b/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.cpp new file mode 100644 index 00000000000..6af0f29d207 --- /dev/null +++ b/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.cpp @@ -0,0 +1,99 @@ +/** + * Copyright (C) 2018-present MongoDB, Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the Server Side Public License, version 1, + * as published by MongoDB, Inc. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * Server Side Public License for more details. + * + * You should have received a copy of the Server Side Public License + * along with this program. If not, see + * <http://www.mongodb.com/licensing/server-side-public-license>. + * + * As a special exception, the copyright holders give permission to link the + * code of portions of this program with the OpenSSL library under certain + * conditions as described in each individual source file and distribute + * linked combinations including the program with the OpenSSL library. You + * must comply with the Server Side Public License in all respects for + * all of the code used other than as permitted herein. If you modify file(s) + * with this exception, you may extend this exception to your version of the + * file(s), but you are not obligated to do so. If you do not wish to do so, + * delete this exception statement from your version. If you delete this + * exception statement from all source files in the program, then also delete + * it in the license file. + */ + +#include "mongo/platform/basic.h" + +#include "mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.h" + +#include "mongo/db/pipeline/document_source.h" +#include "mongo/db/pipeline/document_source_mock.h" +#include "mongo/util/assert_util.h" + +namespace mongo { + +std::unique_ptr<Pipeline, PipelineDeleter> +StubMongoProcessInterfaceLookupSingleDocument::makePipeline( + const std::vector<BSONObj>& rawPipeline, + const boost::intrusive_ptr<ExpressionContext>& expCtx, + const MakePipelineOptions opts) { + auto pipeline = uassertStatusOK(Pipeline::parse(rawPipeline, expCtx)); + + if (opts.optimize) { + pipeline->optimizePipeline(); + } + + if (opts.attachCursorSource) { + pipeline = attachCursorSourceToPipeline(expCtx, pipeline.release()); + } + + return pipeline; +} + +std::unique_ptr<Pipeline, PipelineDeleter> +StubMongoProcessInterfaceLookupSingleDocument::attachCursorSourceToPipeline( + const boost::intrusive_ptr<ExpressionContext>& expCtx, Pipeline* ownedPipeline) { + std::unique_ptr<Pipeline, PipelineDeleter> pipeline(ownedPipeline, + PipelineDeleter(expCtx->opCtx)); + pipeline->addInitialSource(DocumentSourceMock::create(_mockResults)); + return pipeline; +} + +boost::optional<Document> StubMongoProcessInterfaceLookupSingleDocument::lookupSingleDocument( + const boost::intrusive_ptr<ExpressionContext>& expCtx, + const NamespaceString& nss, + UUID collectionUUID, + const Document& documentKey, + boost::optional<BSONObj> readConcern, + bool allowSpeculativeMajorityRead) { + // The namespace 'nss' may be different than the namespace on the ExpressionContext in the + // case of a change stream on a whole database so we need to make a copy of the + // ExpressionContext with the new namespace. + auto foreignExpCtx = expCtx->copyWith(nss, collectionUUID, boost::none); + std::unique_ptr<Pipeline, PipelineDeleter> pipeline; + try { + pipeline = makePipeline({BSON("$match" << documentKey)}, foreignExpCtx); + } catch (ExceptionFor<ErrorCodes::NamespaceNotFound>&) { + return boost::none; + } + + auto lookedUpDocument = pipeline->getNext(); + if (auto next = pipeline->getNext()) { + uasserted(ErrorCodes::TooManyMatchingDocuments, + str::stream() << "found more than one document matching " + << documentKey.toString() + << " [" + << lookedUpDocument->toString() + << ", " + << next->toString() + << "]"); + } + return lookedUpDocument; +} + +} // namespace mongo diff --git a/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.h b/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.h new file mode 100644 index 00000000000..089d38b2908 --- /dev/null +++ b/src/mongo/db/pipeline/stub_mongo_process_interface_lookup_single_document.h @@ -0,0 +1,71 @@ +/** + * Copyright (C) 2018-present MongoDB, Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the Server Side Public License, version 1, + * as published by MongoDB, Inc. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * Server Side Public License for more details. + * + * You should have received a copy of the Server Side Public License + * along with this program. If not, see + * <http://www.mongodb.com/licensing/server-side-public-license>. + * + * As a special exception, the copyright holders give permission to link the + * code of portions of this program with the OpenSSL library under certain + * conditions as described in each individual source file and distribute + * linked combinations including the program with the OpenSSL library. You + * must comply with the Server Side Public License in all respects for + * all of the code used other than as permitted herein. If you modify file(s) + * with this exception, you may extend this exception to your version of the + * file(s), but you are not obligated to do so. If you do not wish to do so, + * delete this exception statement from your version. If you delete this + * exception statement from all source files in the program, then also delete + * it in the license file. + */ + +#pragma once + +#include <boost/intrusive_ptr.hpp> +#include <deque> +#include <vector> + +#include "mongo/db/pipeline/document.h" +#include "mongo/db/pipeline/document_source.h" +#include "mongo/db/pipeline/pipeline.h" +#include "mongo/db/pipeline/stub_mongo_process_interface.h" + +namespace mongo { + +/** + * A mock MongoProcessInterface which allows mocking a foreign pipeline. + */ +class StubMongoProcessInterfaceLookupSingleDocument final : public StubMongoProcessInterface { +public: + StubMongoProcessInterfaceLookupSingleDocument( + std::deque<DocumentSource::GetNextResult> mockResults) + : _mockResults(std::move(mockResults)) {} + + std::unique_ptr<Pipeline, PipelineDeleter> makePipeline( + const std::vector<BSONObj>& rawPipeline, + const boost::intrusive_ptr<ExpressionContext>& expCtx, + const MakePipelineOptions opts = MakePipelineOptions{}) final; + + std::unique_ptr<Pipeline, PipelineDeleter> attachCursorSourceToPipeline( + const boost::intrusive_ptr<ExpressionContext>& expCtx, Pipeline* ownedPipeline) final; + + boost::optional<Document> lookupSingleDocument( + const boost::intrusive_ptr<ExpressionContext>& expCtx, + const NamespaceString& nss, + UUID collectionUUID, + const Document& documentKey, + boost::optional<BSONObj> readConcern, + bool allowSpeculativeMajorityRead); + +private: + std::deque<DocumentSource::GetNextResult> _mockResults; +}; +} // namespace mongo |