SERVER-24242 Don't create a vector<BSONElement> just to iterate

1 files changed, 2 insertions, 4 deletions

diff --git a/src/mongo/db/repl/oplog.cpp b/src/mongo/db/repl/oplog.cpp
index ef3c20448a4..e27ff0e2ae1 100644
--- a/src/mongo/db/repl/oplog.cpp
+++ b/src/mongo/db/repl/oplog.cpp
@@ -755,16 +755,14 @@ Status applyOperation_inlock(OperationContext* txn,
 
         if (fieldO.type() == Array) {
             // Batched inserts.
-            Status status{ErrorCodes::NotYetInitialized, ""};
-
             std::vector<BSONObj> insertObjs;
-            for (auto elem : fieldO.Array()) {
+            for (auto elem : fieldO.Obj()) {
                 insertObjs.push_back(elem.Obj());
             }
 
             WriteUnitOfWork wuow(txn);
             OpDebug* const nullOpDebug = nullptr;
-            status = collection->insertDocuments(
+            Status status = collection->insertDocuments(
                 txn, insertObjs.begin(), insertObjs.end(), nullOpDebug, true);
             if (!status.isOK()) {
                 return status;