diff options
| author | William Schultz <william.schultz@mongodb.com> | 2017-11-28 16:20:05 -0500 |
|---|---|---|
| committer | William Schultz <william.schultz@mongodb.com> | 2017-11-28 16:20:05 -0500 |
| commit | 48c4e4eb48e7994a78bee8f3384df2963a1ea407 (patch) | |
| tree | 0bae29d3a511e2d8cb9030ec023119be884276ef /src/mongo/db/repl/storage_interface_impl_test.cpp | |
| parent | a25df7d03ac286f28eadebdd361802ad522e74e9 (diff) | |
| download | mongo-48c4e4eb48e7994a78bee8f3384df2963a1ea407.tar.gz | |
SERVER-31662 Initialize rollback id to 1 and log when it changes
Diffstat (limited to 'src/mongo/db/repl/storage_interface_impl_test.cpp')
| -rw-r--r-- | src/mongo/db/repl/storage_interface_impl_test.cpp | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/src/mongo/db/repl/storage_interface_impl_test.cpp b/src/mongo/db/repl/storage_interface_impl_test.cpp index 9b3e9fada8b..343ee8b5720 100644 --- a/src/mongo/db/repl/storage_interface_impl_test.cpp +++ b/src/mongo/db/repl/storage_interface_impl_test.cpp @@ -280,26 +280,28 @@ TEST_F(StorageInterfaceImplTest, RollbackIdInitializesIncrementsAndReadsProperly StorageInterfaceImpl storage; auto opCtx = getOperationContext(); + // Rollback ID should be initialized to 1. ASSERT_OK(storage.initializeRollbackID(opCtx)); - _assertRollbackIDDocument(opCtx, 0); + _assertRollbackIDDocument(opCtx, 1); auto rbid = unittest::assertGet(storage.getRollbackID(opCtx)); - ASSERT_EQUALS(rbid, 0); + ASSERT_EQUALS(rbid, 1); + // Rollback ID should increment by exactly 1 each time. ASSERT_OK(storage.incrementRollbackID(opCtx)); - _assertRollbackIDDocument(opCtx, 1); + _assertRollbackIDDocument(opCtx, 2); rbid = unittest::assertGet(storage.getRollbackID(opCtx)); - ASSERT_EQUALS(rbid, 1); + ASSERT_EQUALS(rbid, 2); ASSERT_OK(storage.incrementRollbackID(opCtx)); - _assertRollbackIDDocument(opCtx, 2); + _assertRollbackIDDocument(opCtx, 3); rbid = unittest::assertGet(storage.getRollbackID(opCtx)); - ASSERT_EQUALS(rbid, 2); + ASSERT_EQUALS(rbid, 3); } -TEST_F(StorageInterfaceImplTest, IncrementRollbackIDRollsToZeroWhenExceedingMaxInt) { +TEST_F(StorageInterfaceImplTest, IncrementRollbackIDRollsToOneWhenExceedingMaxInt) { StorageInterfaceImpl storage; auto opCtx = getOperationContext(); NamespaceString nss(StorageInterfaceImpl::kDefaultRollbackIdNamespace); @@ -315,16 +317,16 @@ TEST_F(StorageInterfaceImplTest, IncrementRollbackIDRollsToZeroWhenExceedingMaxI ASSERT_EQUALS(rbid, std::numeric_limits<int>::max()); ASSERT_OK(storage.incrementRollbackID(opCtx)); - _assertRollbackIDDocument(opCtx, 0); + _assertRollbackIDDocument(opCtx, 1); rbid = unittest::assertGet(storage.getRollbackID(opCtx)); - ASSERT_EQUALS(rbid, 0); + ASSERT_EQUALS(rbid, 1); ASSERT_OK(storage.incrementRollbackID(opCtx)); - _assertRollbackIDDocument(opCtx, 1); + _assertRollbackIDDocument(opCtx, 2); rbid = unittest::assertGet(storage.getRollbackID(opCtx)); - ASSERT_EQUALS(rbid, 1); + ASSERT_EQUALS(rbid, 2); } TEST_F(StorageInterfaceImplTest, GetRollbackIDReturnsBadStatusIfDocumentHasBadField) { |