SERVER-25572 Fix ASAN clean shutdown logic

During shutdown a number of things are currently happening that shouldn't be:

1. The legacy transport layer is failing to actually close sockets in closeAll. It's doing this
   because the default argument to closeAll is to leave all sockets open on the legacy transport layer
   (versus to close them on the actual interface header).

2. The thing we're checking for in shutdown is wrong. It's just that we've left recv in all db
   workers, rather than that we've left all client workers (so ASAN is occasionally unhappy about
   "leaks")

3. Tests rely on external callers to close sockets. when this contract changes, we take an extra 10
   seconds to shut down every mongod, making some tests time out.

Fix this by adding a counter for actual live workers, so we can track when it's safe to shutdown
correctly. Also fix the typo

1 files changed, 9 insertions, 0 deletions

diff --git a/src/mongo/db/service_context.cpp b/src/mongo/db/service_context.cpp
index 585ffefb430..ffaa0f7f128 100644
--- a/src/mongo/db/service_context.cpp
+++ b/src/mongo/db/service_context.cpp
@@ -34,6 +34,7 @@
 #include "mongo/db/client.h"
 #include "mongo/db/operation_context.h"
 #include "mongo/stdx/memory.h"
+#include "mongo/transport/service_entry_point.h"
 #include "mongo/transport/session.h"
 #include "mongo/transport/transport_layer.h"
 #include "mongo/transport/transport_layer_manager.h"
@@ -158,6 +159,10 @@ transport::TransportLayer* ServiceContext::getTransportLayer() const {
     return _transportLayerManager.get();
 }
 
+ServiceEntryPoint* ServiceContext::getServiceEntryPoint() const {
+    return _serviceEntryPoint.get();
+}
+
 Status ServiceContext::addAndStartTransportLayer(std::unique_ptr<transport::TransportLayer> tl) {
     return _transportLayerManager->addAndStartTransportLayer(std::move(tl));
 }
@@ -186,6 +191,10 @@ void ServiceContext::setPreciseClockSource(std::unique_ptr<ClockSource> newSourc
     _preciseClockSource = std::move(newSource);
 }
 
+void ServiceContext::setServiceEntryPoint(std::unique_ptr<ServiceEntryPoint> sep) {
+    _serviceEntryPoint = std::move(sep);
+}
+
 void ServiceContext::ClientDeleter::operator()(Client* client) const {
     ServiceContext* const service = client->getServiceContext();
     {