SERVER-29305 `DBDirectClient::call` uses OpContext

Presently it directly calls `assembleResponse`, which is responsible
for a cyclic dependency.  This functionality is available through
the `ServiceContext` mechanism, and thus needn't directly use
`assembleResponse`.

The `ServiceEntryPoint` member of `ServiceContext` is set through
a setter, which isn't always called, so we initialize the global
entry through a factory function.

This also removes the superfluous argument for `HostAndPort`, as
that was used to track whether the call was made from within the
`DbDirectClient` object itself or from the network -- a separate
bit in the `OperationContext` indicates that state.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/mongo/db/service_context.h b/src/mongo/db/service_context.h
index 566ed7fb650..c4f41bd5651 100644
--- a/src/mongo/db/service_context.h
+++ b/src/mongo/db/service_context.h
@@ -389,7 +389,7 @@ public:
     void setPreciseClockSource(std::unique_ptr<ClockSource> newSource);
 
     /**
-     * Binds the service entry point implementation to the service context
+     * Binds the service entry point implementation to the service context.
      */
     void setServiceEntryPoint(std::unique_ptr<ServiceEntryPoint> sep);