SERVER-34798 Remove ServiceContext subclasses and use new ServiceContext in every unit test.

This patch does several loosely related and surprisingly hard to separate things.

1.) Make the ServiceContext class final

2.) Create a mechanism, called ConstructorActions, for running methods on
ServiceContexts immediately after they're built and immediately before they're
destroyed.

3.) Introduce / improve test fixture base classes for tests, giving them fresh
ServiceContext instances for each test case. There is one fixture for tests that
need a storage engine and another for those that do not.

4.) Make several remaining global variables SC decorations in support of (3)

5.) Replace many MONGO_INITIALIZERS that access getGlobalServiceContext with the
new constructor-actions system, which is needed for (3.)

6.) Fix up tests to use the fixtures from (3) and fix tests that silently used
different service contexts in together in a technically illegal fashion that now
breaks.

7.) Utilize (2) as necessary to simplify initialization of new ServiceContexts,
simplifying the fixtures in (3).

1 files changed, 0 insertions, 46 deletions

diff --git a/src/mongo/db/service_context_registrar.h b/src/mongo/db/service_context_registrar.h
deleted file mode 100644
index 72f6e6ea2dd..00000000000
--- a/src/mongo/db/service_context_registrar.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/**
-*    Copyright (C) 2018 MongoDB Inc.
-*
-*    This program is free software: you can redistribute it and/or  modify
-*    it under the terms of the GNU Affero General Public License, version 3,
-*    as published by the Free Software Foundation.
-*
-*    This program is distributed in the hope that it will be useful,
-*    but WITHOUT ANY WARRANTY; without even the implied warranty of
-*    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-*    GNU Affero General Public License for more details.
-*
-*    You should have received a copy of the GNU Affero General Public License
-*    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*
-*    As a special exception, the copyright holders give permission to link the
-*    code of portions of this program with the OpenSSL library under certain
-*    conditions as described in each individual source file and distribute
-*    linked combinations including the program with the OpenSSL library. You
-*    must comply with the GNU Affero General Public License in all respects for
-*    all of the code used other than as permitted herein. If you modify file(s)
-*    with this exception, you may extend this exception to your version of the
-*    file(s), but you are not obligated to do so. If you do not wish to do so,
-*    delete this exception statement from your version. If you delete this
-*    exception statement from all source files in the program, then also delete
-*    it in the license file.
-*/
-
-#pragma once
-
-#include <functional>
-#include <memory>
-
-namespace mongo {
-class ServiceContext;
-
-// This is a initialization registration system similar to MONGO_INITIALIZER. But it cannot be an
-// MONGO_INITIALIZER because we need to create the service context before the MONGO_INITIALIZERS
-// execute. This class should probably be refactored to use the shim system from this ticket:
-// https://jira.mongodb.org/browse/SERVER-32645
-class ServiceContextRegistrar {
-public:
-    explicit ServiceContextRegistrar(std::function<std::unique_ptr<ServiceContext>()> fn);
-};
-
-}  // namespace mongo