SERVER-30803 Better error message for invalid result with $inc/$mul.

This adds back a check that got lost in the translation from
modifier_inc to ArithmeticNode.

1 files changed, 17 insertions, 0 deletions

diff --git a/src/mongo/db/update/arithmetic_node_test.cpp b/src/mongo/db/update/arithmetic_node_test.cpp
index a0a74654ac0..105f2019057 100644
--- a/src/mongo/db/update/arithmetic_node_test.cpp
+++ b/src/mongo/db/update/arithmetic_node_test.cpp
@@ -590,6 +590,23 @@ TEST_F(ArithmeticNodeTest, ApplyIncToStringFails) {
                                 "\"test_object\"} has the field 'a' of non-numeric type string");
 }
 
+TEST_F(ArithmeticNodeTest, OverflowingOperationFails) {
+    auto update = fromjson("{$mul: {a: 2}}");
+    const CollatorInterface* collator = nullptr;
+    ArithmeticNode node(ArithmeticNode::ArithmeticOp::kMultiply);
+    ASSERT_OK(node.init(update["$mul"]["a"], collator));
+
+    mutablebson::Document doc(fromjson("{_id: 'test_object', a: NumberLong(9223372036854775807)}"));
+    setPathTaken("a");
+    addIndexedPath("a");
+    ASSERT_THROWS_CODE_AND_WHAT(node.apply(getApplyParams(doc.root()["a"])),
+                                AssertionException,
+                                ErrorCodes::BadValue,
+                                "Failed to apply $mul operations to current value "
+                                "((NumberLong)9223372036854775807) for document {_id: "
+                                "\"test_object\"}");
+}
+
 TEST_F(ArithmeticNodeTest, ApplyNewPath) {
     auto update = fromjson("{$inc: {a: 2}}");
     const CollatorInterface* collator = nullptr;