SERVER-15210 SERVER-15211 remove OID undefined behavior and make it endian aware

Closes #784

Signed-off-by: Benety Goh <benety@mongodb.com>

1 files changed, 4 insertions, 19 deletions

diff --git a/src/mongo/dbtests/jsobjtests.cpp b/src/mongo/dbtests/jsobjtests.cpp
index 2b4e7918017..23bbb7b9707 100644
--- a/src/mongo/dbtests/jsobjtests.cpp
+++ b/src/mongo/dbtests/jsobjtests.cpp
@@ -1242,7 +1242,7 @@ namespace JsobjTests {
                 OID b;
 
                 a.init();
-                b.init( a.str() );
+                b.init( a.toString() );
 
                 ASSERT( a == b );
             }
@@ -1258,9 +1258,9 @@ namespace JsobjTests {
                 BSONObj o = b.obj();
                 keyTest(o);
 
-                ASSERT( o["a"].__oid().str() == "000000000000000000000000" );
-                ASSERT( o["b"].__oid().str() == "000000000000000000000000" );
-                ASSERT( o["c"].__oid().str() != "000000000000000000000000" );
+                ASSERT( o["a"].__oid().toString() == "000000000000000000000000" );
+                ASSERT( o["b"].__oid().toString() == "000000000000000000000000" );
+                ASSERT( o["c"].__oid().toString() != "000000000000000000000000" );
 
             }
         };
@@ -1316,20 +1316,6 @@ namespace JsobjTests {
             }
         };
 
-        class Seq {
-        public:
-            void run() {
-                for ( int i=0; i<10000; i++ ) {
-                    OID a;
-                    OID b;
-                    
-                    a.initSequential();
-                    b.initSequential();
-
-                    ASSERT( a < b );
-                }
-            }
-        };
     } // namespace OIDTests
 
 
@@ -2285,7 +2271,6 @@ namespace JsobjTests {
             add< OIDTests::increasing >();
             add< OIDTests::ToDate >();
             add< OIDTests::FromDate >();
-            add< OIDTests::Seq >();
             add< ValueStreamTests::LabelBasic >();
             add< ValueStreamTests::LabelShares >();
             add< ValueStreamTests::LabelDouble >();