SERVER-43821 Make PlanStage and PlanExecutor return errors by throwing

This eliminates the need for the FAILURE status codes in
PlanStage and PlanExecutor, and brings query execution's
error reporting more in line with that of the rest of the
server. It also makes it easier for future implementations
of PlanExecutor to comply with the interface.

1 files changed, 0 insertions, 3 deletions

diff --git a/src/mongo/dbtests/query_stage_ixscan.cpp b/src/mongo/dbtests/query_stage_ixscan.cpp
index c7f3d0aa5fd..0a46f2a34ae 100644
--- a/src/mongo/dbtests/query_stage_ixscan.cpp
+++ b/src/mongo/dbtests/query_stage_ixscan.cpp
@@ -85,10 +85,7 @@ public:
         PlanStage::StageState state = PlanStage::NEED_TIME;
         while (PlanStage::ADVANCED != state) {
             state = ixscan->work(&out);
-
-            // There are certain states we shouldn't get.
             ASSERT_NE(PlanStage::IS_EOF, state);
-            ASSERT_NE(PlanStage::FAILURE, state);
         }
 
         return _ws.get(out);