SERVER-21504 NetworkInterfaceASIO logging tweaks

- move "connection failed" log messages to log level 1
- make sure we log commands that failed due to cancellation

1 files changed, 10 insertions, 6 deletions

diff --git a/src/mongo/executor/network_interface_asio_command.cpp b/src/mongo/executor/network_interface_asio_command.cpp
index 5c2a02e5a28..9e21021d70e 100644
--- a/src/mongo/executor/network_interface_asio_command.cpp
+++ b/src/mongo/executor/network_interface_asio_command.cpp
@@ -279,9 +279,18 @@ void NetworkInterfaceASIO::_completeOperation(AsyncOp* op, const ResponseStatus&
     }
 
     if (op->_inSetup) {
+        // If we are in setup we should only be here if we failed to connect.
+        invariant(!resp.isOK());
         // If we fail during connection, we won't be able to access any of our members after calling
         // op->finish().
-        log() << "Failed to connect to " << op->request().target << " - " << resp.getStatus();
+        LOG(1) << "Failed to connect to " << op->request().target << " - " << resp.getStatus();
+    }
+
+    if (!resp.isOK()) {
+        // In the case that resp is not OK, but _inSetup is false, we are using a connection that
+        // we got from the pool to execute a command, but it failed for some reason.
+        LOG(2) << "Failed to execute command: " << op->request().toString()
+               << " reason: " << resp.getStatus();
     }
 
     op->finish(resp);
@@ -302,11 +311,6 @@ void NetworkInterfaceASIO::_completeOperation(AsyncOp* op, const ResponseStatus&
         _inProgress.erase(iter);
     }
 
-    if (!resp.isOK()) {
-        LOG(2) << "Failed to execute command: " << op->request().toString()
-               << " reason: " << resp.getStatus();
-    }
-
     invariant(ownedOp);
 
     auto conn = std::move(op->_connectionPoolHandle);