diff options
author | David Storch <david.storch@mongodb.com> | 2020-03-23 16:21:45 -0400 |
---|---|---|
committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2020-03-23 22:22:39 +0000 |
commit | 65f447b27e9b3db0315dd52d97d9e26fa462916c (patch) | |
tree | 4acb87c8abd23a9b5469cc1093772d92d1dd5b1d /src/mongo/executor | |
parent | 99065500588a7c7dfa4cf5c51df2e1ee99bf400f (diff) | |
download | mongo-65f447b27e9b3db0315dd52d97d9e26fa462916c.tar.gz |
SERVER-45579 Remove FCV 4.4 check guarding addition of 'comment' to remote command requests
Diffstat (limited to 'src/mongo/executor')
-rw-r--r-- | src/mongo/executor/remote_command_request.cpp | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/src/mongo/executor/remote_command_request.cpp b/src/mongo/executor/remote_command_request.cpp index d5541f2ad59..e27a07968dc 100644 --- a/src/mongo/executor/remote_command_request.cpp +++ b/src/mongo/executor/remote_command_request.cpp @@ -34,7 +34,6 @@ #include <fmt/format.h> #include "mongo/bson/simple_bsonobj_comparator.h" -#include "mongo/db/server_options.h" #include "mongo/platform/atomic_word.h" #include "mongo/util/str.h" @@ -70,17 +69,9 @@ RemoteCommandRequestBase::RemoteCommandRequestBase(RequestId requestId, fireAndForgetMode(fireAndForgetMode) { // If there is a comment associated with the current operation, append it to the command that we // are about to dispatch to the shards. - // - // TODO SERVER-45579: Remove this FCV check after branching for 4.5. This is needed only for - // compatibility with 4.2 during the 4.2 <=> 4.4 upgrade/downgrade process. - if (serverGlobalParams.featureCompatibility.isVersionInitialized() && - serverGlobalParams.featureCompatibility.getVersion() == - ServerGlobalParams::FeatureCompatibility::Version::kFullyUpgradedTo44 && - opCtx && opCtx->getComment() && !theCmdObj["comment"]) { - cmdObj = theCmdObj.addField(*opCtx->getComment()); - } else { - cmdObj = theCmdObj; - } + cmdObj = opCtx && opCtx->getComment() && !theCmdObj["comment"] + ? theCmdObj.addField(*opCtx->getComment()) + : cmdObj = theCmdObj; if (hedgeOptions) { operationKey.emplace(UUID::gen()); |