SERVER-23703 Make NumberDecimal accepts only valid strings

2 files changed, 11 insertions, 1 deletions

diff --git a/src/mongo/platform/decimal128.cpp b/src/mongo/platform/decimal128.cpp
index def39a899e9..d0af1ea5bb9 100644
--- a/src/mongo/platform/decimal128.cpp
+++ b/src/mongo/platform/decimal128.cpp
@@ -250,11 +250,17 @@ Decimal128::Decimal128(double doubleValue,
 
 Decimal128::Decimal128(std::string stringValue, RoundingMode roundMode) {
     std::uint32_t throwAwayFlag = 0;
+    *this = Decimal128(stringValue, &throwAwayFlag, roundMode);
+}
+
+Decimal128::Decimal128(std::string stringValue,
+                       std::uint32_t* signalingFlags,
+                       RoundingMode roundMode) {
     std::unique_ptr<char[]> charInput(new char[stringValue.size() + 1]);
     std::copy(stringValue.begin(), stringValue.end(), charInput.get());
     charInput[stringValue.size()] = '\0';
     BID_UINT128 dec128;
-    dec128 = bid128_from_string(charInput.get(), roundMode, &throwAwayFlag);
+    dec128 = bid128_from_string(charInput.get(), roundMode, signalingFlags);
     _value = libraryTypeToValue(dec128);
 }
 
diff --git a/src/mongo/platform/decimal128.h b/src/mongo/platform/decimal128.h
index f347ec42f70..6fa6d6d3e2c 100644
--- a/src/mongo/platform/decimal128.h
+++ b/src/mongo/platform/decimal128.h
@@ -177,6 +177,10 @@ public:
      */
     explicit Decimal128(std::string stringValue, RoundingMode roundMode = kRoundTiesToEven);
 
+    Decimal128(std::string stringValue,
+               std::uint32_t* signalingFlag,
+               RoundingMode roundMode = kRoundTiesToEven);
+
     /**
      * This function gets the inner Value struct storing a Decimal128 value.
      */