SERVER-9434 Audit and Normalize Process Exit Codes

- Put all references to ExitCode enumerators under an enum class to namespace
  all the enumerators and avoid polluting the mongo namespace with possible
  naming collisions.
- Added magic-number exit codes to exit_code.h like 50 & 51
  (LauncherMiddleError & LauncherError respectively).
- Reserved a range of exit codes to account for FreeBSD's usage of 64-78.
- Renamed all enums with removal of EXIT_ which could conflict or get confused
  with built-in macros.
- camelCased all ExitCode enum values.
- Added the generic - ExitCode::fail - for returning 1 as failure.
- Added explicit dependency on the exit_code.h header for all files using
  ExitCode's.
- Removed all references to implementation-defined exit codes like EXIT_FAILURE
  and EXIT_SUCCESS.
- Narrowed return values of the shell's undocumented quit() argument to portable
  values within 0-255, 0/ExitCode::clean otherwise.
- Deprecated 8 unused ExitCode's
  - java
  - oomMalloc
  - oomRealloc
  - fs
  - clockSkew
  - windowsServiceStop
  - possibleCorruption
  - test
- Wrapped the 2 Windows-only ExitCode's in #ifdef's
  - ntServiceError
  - windowsServiceStop

2 files changed, 6 insertions, 2 deletions

diff --git a/src/mongo/platform/visibility_test1.cpp b/src/mongo/platform/visibility_test1.cpp
index 33341d8a5e0..f52253eedd7 100644
--- a/src/mongo/platform/visibility_test1.cpp
+++ b/src/mongo/platform/visibility_test1.cpp
@@ -30,10 +30,12 @@
 #include "mongo/platform/basic.h"
 
 #include "mongo/platform/visibility_test_lib1.h"
+#include "mongo/util/exit_code.h"
 
 #include <cstdlib>
 
 int main(int argc, char* argv[]) {
     mongo::visibility_test_lib1::Base b("hello");
-    return (b.name() == "hello") ? EXIT_SUCCESS : EXIT_FAILURE;
+    return (b.name() == "hello") ? static_cast<int>(mongo::ExitCode::clean)
+                                 : static_cast<int>(mongo::ExitCode::fail);
 }
diff --git a/src/mongo/platform/visibility_test2.cpp b/src/mongo/platform/visibility_test2.cpp
index baf69b36412..56621f7b167 100644
--- a/src/mongo/platform/visibility_test2.cpp
+++ b/src/mongo/platform/visibility_test2.cpp
@@ -30,10 +30,12 @@
 #include "mongo/platform/basic.h"
 
 #include "mongo/platform/visibility_test_lib2.h"
+#include "mongo/util/exit_code.h"
 
 #include <cstdlib>
 
 int main(int argc, char* argv[]) {
     mongo::visibility_test_lib2::Derived d("hello", argc);
-    return (d.value() == argc) ? EXIT_SUCCESS : EXIT_FAILURE;
+    return (d.value() == argc) ? static_cast<int>(mongo::ExitCode::clean)
+                               : static_cast<int>(mongo::ExitCode::fail);
 }