SERVER-27211 de-duplicate symbol `isMongos`

A hidden global variable representing the "is Mongos process" state
can now be accessed and updated by the `is_mongos.h` interface.  All
tests defining their own versions (and test crutches) are replaced
with calls to global registration of the desired state of this variable.
The `mongos` main executable now sets this hidden global state as part
of its startup code.

1 files changed, 1 insertions, 4 deletions

diff --git a/src/mongo/s/mongos_options.h b/src/mongo/s/mongos_options.h
index 8ac3a1d9321..3e2f5ff4623 100644
--- a/src/mongo/s/mongos_options.h
+++ b/src/mongo/s/mongos_options.h
@@ -31,6 +31,7 @@
 #include "mongo/base/status.h"
 #include "mongo/client/connection_string.h"
 #include "mongo/db/server_options.h"
+#include "mongo/s/is_mongos.h"
 #include "mongo/util/options_parser/environment.h"
 #include "mongo/util/options_parser/option_section.h"
 
@@ -78,8 +79,4 @@ Status validateMongosOptions(const moe::Environment& params);
 Status canonicalizeMongosOptions(moe::Environment* params);
 
 Status storeMongosOptions(const moe::Environment& params);
-
-// This function should eventually go away, but needs to be here now because the sorter and
-// the version manager must know at runtime which binary it is in.
-bool isMongos();
 }