diff options
author | Ben Caimano <ben.caimano@mongodb.com> | 2019-09-09 18:45:01 +0000 |
---|---|---|
committer | evergreen <evergreen@mongodb.com> | 2019-09-09 18:45:01 +0000 |
commit | 0f16c5fc452d16c5a92e43e9fdd96f3822f05271 (patch) | |
tree | 890ff8a80ae78d7831452aedb30feb9e76be1567 /src/mongo/s/transaction_router.cpp | |
parent | f4e387fa1b7e369ce067650bdda9c8676683b929 (diff) | |
download | mongo-0f16c5fc452d16c5a92e43e9fdd96f3822f05271.tar.gz |
SERVER-42908 Add ErrorCodes to retryable errors to match drivers
Diffstat (limited to 'src/mongo/s/transaction_router.cpp')
-rw-r--r-- | src/mongo/s/transaction_router.cpp | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/mongo/s/transaction_router.cpp b/src/mongo/s/transaction_router.cpp index 5b791ab0270..81cd77fcab0 100644 --- a/src/mongo/s/transaction_router.cpp +++ b/src/mongo/s/transaction_router.cpp @@ -158,13 +158,6 @@ bool isReadConcernLevelAllowedInTransaction(repl::ReadConcernLevel readConcernLe readConcernLevel == repl::ReadConcernLevel::kLocalReadConcern; } -// Returns if the error code would be considered a retryable error for a retryable write. -bool isRetryableWritesError(ErrorCodes::Error code) { - return std::find(RemoteCommandRetryScheduler::kAllRetriableErrors.begin(), - RemoteCommandRetryScheduler::kAllRetriableErrors.end(), - code) != RemoteCommandRetryScheduler::kAllRetriableErrors.end(); -} - // Returns if a transaction's commit result is unknown based on the given statuses. A result is // considered unknown if it would be given the "UnknownTransactionCommitResult" as defined by the // driver transactions specification or fails with one of the errors for invalid write concern that @@ -176,8 +169,8 @@ bool isRetryableWritesError(ErrorCodes::Error code) { // https://github.com/mongodb/specifications/blob/master/source/transactions/transactions.rst#unknowntransactioncommitresult. bool isCommitResultUnknown(const Status& commitStatus, const Status& commitWCStatus) { if (!commitStatus.isOK()) { - return isRetryableWritesError(commitStatus.code()) || - ErrorCodes::isExceededTimeLimitError(commitStatus.code()) || + return ErrorCodes::isRetriableError(commitStatus) || + ErrorCodes::isExceededTimeLimitError(commitStatus) || commitStatus.code() == ErrorCodes::TransactionTooOld; } |