SERVER-5842 don't assert on call inside native_helper

The native_helper() routine in engine_spidermonkey.cpp calls
functions that use Boost, and Boost will throw std:exceptions
on cases such as file and directory protection errors, badly
formed filenames, and others, so we can't call fassertFailed
on these exceptions; they are user errors and need to be passed
back to the JavaScript caller.

1 files changed, 11 insertions, 1 deletions

diff --git a/src/mongo/scripting/engine_spidermonkey.cpp b/src/mongo/scripting/engine_spidermonkey.cpp
index cbc4e9aa87c..7bef1b0a5e1 100644
--- a/src/mongo/scripting/engine_spidermonkey.cpp
+++ b/src/mongo/scripting/engine_spidermonkey.cpp
@@ -1195,7 +1195,17 @@ namespace mongo {
                 a = args.obj();
             }
 
-            BSONObj out = func( a, data );
+            BSONObj out;
+            try {
+                out = func( a, data );
+            }
+            catch ( std::exception& e ) {
+                if ( ! JS_IsExceptionPending( cx ) ) {
+                    JS_ReportError( cx, e.what() );
+                }
+                return JS_FALSE;
+            }
+
             if ( out.isEmpty() ) {
                 *rval = JSVAL_VOID;
             }