SERVER-20080 Constrain ctor calls for JS types

Several types shouldn't be called as a ctor:
* NativeFunction
* Cursor
* CursorHandle
* NativeFunction

This prevents them from being called as such.

1 files changed, 1 insertions, 7 deletions

diff --git a/src/mongo/scripting/mozjs/bson.cpp b/src/mongo/scripting/mozjs/bson.cpp
index 308e29d90f3..9c972a6b3fc 100644
--- a/src/mongo/scripting/mozjs/bson.cpp
+++ b/src/mongo/scripting/mozjs/bson.cpp
@@ -75,7 +75,7 @@ BSONHolder* getHolder(JSObject* obj) {
 void BSONInfo::make(JSContext* cx, JS::MutableHandleObject obj, BSONObj bson, bool ro) {
     auto scope = getScope(cx);
 
-    scope->getBsonProto().newInstance(obj);
+    scope->getBsonProto().newObject(obj);
     JS_SetPrivate(obj, new BSONHolder(bson, ro));
 }
 
@@ -193,12 +193,6 @@ void BSONInfo::resolve(JSContext* cx, JS::HandleObject obj, JS::HandleId id, boo
     }
 }
 
-void BSONInfo::construct(JSContext* cx, JS::CallArgs args) {
-    auto scope = getScope(cx);
-
-    scope->getBsonProto().newObject(args.rval());
-}
-
 std::tuple<BSONObj*, bool> BSONInfo::originalBSON(JSContext* cx, JS::HandleObject obj) {
     std::tuple<BSONObj*, bool> out(nullptr, false);