SERVER-21692 check return of JS_NewRuntime

Moved an uassert away from a call site.  Opens up the chance for nullptr
dereferences.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/mongo/scripting/mozjs/implscope.cpp b/src/mongo/scripting/mozjs/implscope.cpp
index 5d099a6b254..4a90bdc76d7 100644
--- a/src/mongo/scripting/mozjs/implscope.cpp
+++ b/src/mongo/scripting/mozjs/implscope.cpp
@@ -230,6 +230,7 @@ MozJSImplScope::MozRuntime::MozRuntime(const MozJSScriptEngine* engine) {
         }
 
         _runtime = JS_NewRuntime(kMaxBytesBeforeGC);
+        uassert(ErrorCodes::JSInterpreterFailure, "Failed to initialize JSRuntime", _runtime);
 
         // We turn on a variety of optimizations if the jit is enabled
         if (engine->isJITEnabled()) {
@@ -259,8 +260,6 @@ MozJSImplScope::MozRuntime::MozRuntime(const MozJSScriptEngine* engine) {
         }
     }
 
-    uassert(ErrorCodes::JSInterpreterFailure, "Failed to initialize JSRuntime", _runtime);
-
     _context = JS_NewContext(_runtime, kStackChunkSize);
     uassert(ErrorCodes::JSInterpreterFailure, "Failed to initialize JSContext", _context);
 }