SERVER-33437 Make Decorables not type-erased.

The current Decorable system type-erases the most derived (Decorated)
type when registering Decorations.  This is illegal as derived classes
which are no longer standard-layout can have the `Decorable` base
class reordered with respect to the base address of their storage.

This also removes the "with-owner" forms of declaring a decoration,
which caused problems with layout.  The decoration handles have
been modified to provide mechanisms to get back to the owner
directly, given a pointer or reference to the decoration.

1 files changed, 0 insertions, 10 deletions

diff --git a/src/mongo/util/SConscript b/src/mongo/util/SConscript
index dbac968868e..dc46c7a6fa9 100644
--- a/src/mongo/util/SConscript
+++ b/src/mongo/util/SConscript
@@ -59,22 +59,12 @@ debuggerEnv.Library(
     ]
 )
 
-env.Library(
-    target='decorable',
-    source=[
-        'decoration_container.cpp',
-        'decoration_registry.cpp',
-    ],
-    LIBDEPS=[]
-    )
-
 env.CppUnitTest(
     target='decorable_test',
     source=[
         'decorable_test.cpp'
         ],
     LIBDEPS=[
-        'decorable',
         ]
     )