SERVER-6908 Don't pass strings by value

Change lots of code to take <string> arguments by const ref instead
of by value; minor changes to surrounding code.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/mongo/util/mmap.cpp b/src/mongo/util/mmap.cpp
index bedbd70fb44..756f46e4c07 100644
--- a/src/mongo/util/mmap.cpp
+++ b/src/mongo/util/mmap.cpp
@@ -44,7 +44,7 @@ namespace mongo {
     /* Create. Must not exist.
     @param zero fill file with zeros when true
     */
-    void* MemoryMappedFile::create(string filename, unsigned long long len, bool zero) {
+    void* MemoryMappedFile::create(const std::string& filename, unsigned long long len, bool zero) {
         uassert( 13468, string("can't create file already exists ") + filename, ! boost::filesystem::exists(filename) );
         void *p = map(filename.c_str(), len);
         if( p && zero ) {
@@ -190,7 +190,7 @@ namespace mongo {
         mmfiles.insert(this);
     }
 
-    void MongoFile::setFilename(string fn) {
+    void MongoFile::setFilename(const std::string& fn) {
         LockMongoFilesExclusive lk;
         verify( _filename.empty() );
         _filename = fn;