SERVER-48291 Add global dependency pushdown to libdeps

We sometimes have situations where a dependency applies at a large
scope, such as in the case of tcmalloc, which can apply everywhere. What
we have done previously is to hack these dependencies into the LIBDEPS
environment variable by adding a builder to all nodes that can produce a
compiler result. This is, as stated previously, hackish and hard to
control, and it results in adding a Public dependency to all those
nodes.

What we now do instead is to define LIBDEPS_GLOBAL on the *build
environment* (not the Builder node) listing the targets we would like to
push down to all other nodes below that point. This has the effect of
adding those targets as Private dependencies on all Builder nodes from
that point downward, which means some common Public dependencies can be
converted to a Private dependency that is stated only once.

1 files changed, 6 insertions, 0 deletions

diff --git a/src/third_party/unwind/SConscript b/src/third_party/unwind/SConscript
index 3ee569667a1..983478dd22a 100644
--- a/src/third_party/unwind/SConscript
+++ b/src/third_party/unwind/SConscript
@@ -128,5 +128,11 @@ env.Library(
     # We don't want the shim_allocator hack to apply to this library, since
     # otherwise we would create a loop, since tcmalloc might use us. That should
     # be OK, unless libunwind had static initializers that invoked malloc.
+    LIBDEPS_GLOBAL=[
+        dep
+        for dep in env.get('LIBDEPS_GLOBAL', [])
+        if not dep.endswith('shim_allocator')
+    ],
+    # TODO: Remove when SERVER-48291 is merged into stable build tools
     DISABLE_ALLOCATOR_SHIM_INJECTION=True,
 )