Import wiredtiger: 2b048c9ad2dfde7ad9c2a1329bc082dfc882aec7 from branch mongodb-3.6

ref: 47e8c3d1d2..2b048c9ad2
for: 3.5.10

SERVER-29439  WiredTiger turtle file "MoveFileExW: Access is denied." error.
WT-3251       Remove interim buffer used to split pages during reconciliation
WT-3367       Switch OSX builders to 10.12
WT-3370       Heap use after free in txn recover code
WT-3371       Make Windows/MSVC build warnings fatal.
WT-3379       Avoid a performance regression on secondaries

1 files changed, 4 insertions, 6 deletions

diff --git a/src/third_party/wiredtiger/SConstruct b/src/third_party/wiredtiger/SConstruct
index 22f869e02e7..2661807594d 100644
--- a/src/third_party/wiredtiger/SConstruct
+++ b/src/third_party/wiredtiger/SConstruct
@@ -67,15 +67,11 @@ var.Add('CPPPATH', 'C Preprocessor include path', [
 ])
 
 var.Add('CFLAGS', 'C Compiler Flags', [
-    "/Z7", # Generate debugging symbols
     "/wd4090", # Ignore warning about mismatched const qualifiers
     "/wd4996", # Ignore deprecated functions
     "/W3", # Warning level 3
-    #"/we4244", # Possible loss of data
-    "/we4013", # Error on undefined functions
-    #"/we4047", # Indirection differences in types
-    #"/we4024", # Differences in parameter types
-    #"/we4100", # Unreferenced local parameter
+    "/WX", # Warnings are fatal
+    "/Z7", # Generate debugging symbols
     "/TC", # Compile as C code
     #"/Od", # Disable optimization
     "/Ob1", # inline expansion
@@ -338,6 +334,8 @@ if GetOption("lang-python"):
             "-nodefaultctor",
             "-nodefaultdtor",
             ])
+    # Ignore warnings in swig-generated code.
+    pythonEnv['CFLAGS'].remove("/WX")
 
     swiglib = pythonEnv.SharedLibrary('_wiredtiger',
                       [ 'lang\python\wiredtiger.i'],