SERVER-32098 add unit test for convertToCapped

2 files changed, 164 insertions, 0 deletions

diff --git a/src/mongo/db/catalog/SConscript b/src/mongo/db/catalog/SConscript
index b8d66ce5cd7..c21cde8582d 100644
--- a/src/mongo/db/catalog/SConscript
+++ b/src/mongo/db/catalog/SConscript
@@ -291,6 +291,22 @@ env.Library(
 )
 
 env.CppUnitTest(
+    target='capped_utils_test',
+    source=[
+        'capped_utils_test.cpp',
+    ],
+    LIBDEPS=[
+        'catalog_helpers',
+        '$BUILD_DIR/mongo/db/db_raii',
+        '$BUILD_DIR/mongo/db/namespace_string',
+        '$BUILD_DIR/mongo/db/repl/repl_coordinator_interface',
+        '$BUILD_DIR/mongo/db/repl/replmocks',
+        '$BUILD_DIR/mongo/db/repl/storage_interface_impl',
+        '$BUILD_DIR/mongo/db/service_context_d_test_fixture',
+    ],
+)
+
+env.CppUnitTest(
     target='create_collection_test',
     source=[
         'create_collection_test.cpp',
diff --git a/src/mongo/db/catalog/capped_utils_test.cpp b/src/mongo/db/catalog/capped_utils_test.cpp
new file mode 100644
index 00000000000..5a8294358af
--- /dev/null
+++ b/src/mongo/db/catalog/capped_utils_test.cpp
@@ -0,0 +1,148 @@
+/**
+ *    Copyright 2017 MongoDB Inc.
+ *
+ *    This program is free software: you can redistribute it and/or  modify
+ *    it under the terms of the GNU Affero General Public License, version 3,
+ *    as published by the Free Software Foundation.
+ *
+ *    This program is distributed in the hope that it will be useful,
+ *    but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *    GNU Affero General Public License for more details.
+ *
+ *    You should have received a copy of the GNU Affero General Public License
+ *    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ *    As a special exception, the copyright holders give permission to link the
+ *    code of portions of this program with the OpenSSL library under certain
+ *    conditions as described in each individual source file and distribute
+ *    linked combinations including the program with the OpenSSL library. You
+ *    must comply with the GNU Affero General Public License in all respects for
+ *    all of the code used other than as permitted herein. If you modify file(s)
+ *    with this exception, you may extend this exception to your version of the
+ *    file(s), but you are not obligated to do so. If you do not wish to do so,
+ *    delete this exception statement from your version. If you delete this
+ *    exception statement from all source files in the program, then also delete
+ *    it in the license file.
+ */
+
+#include "mongo/platform/basic.h"
+
+#include "mongo/db/catalog/capped_utils.h"
+#include "mongo/db/catalog/collection_catalog_entry.h"
+#include "mongo/db/client.h"
+#include "mongo/db/db_raii.h"
+#include "mongo/db/repl/replication_coordinator.h"
+#include "mongo/db/repl/replication_coordinator_mock.h"
+#include "mongo/db/repl/storage_interface_impl.h"
+#include "mongo/db/service_context_d_test_fixture.h"
+#include "mongo/stdx/memory.h"
+#include "mongo/unittest/unittest.h"
+
+namespace {
+
+using namespace mongo;
+
+class CappedUtilsTest : public ServiceContextMongoDTest {
+private:
+    void setUp() override;
+    void tearDown() override;
+
+protected:
+    // Use StorageInterface to access storage features below catalog interface.
+    std::unique_ptr<repl::StorageInterface> _storage;
+};
+
+void CappedUtilsTest::setUp() {
+    // Set up mongod.
+    ServiceContextMongoDTest::setUp();
+
+    auto service = getServiceContext();
+
+    // Set up ReplicationCoordinator and ensure that we are primary.
+    auto replCoord = stdx::make_unique<repl::ReplicationCoordinatorMock>(service);
+    ASSERT_OK(replCoord->setFollowerMode(repl::MemberState::RS_PRIMARY));
+    repl::ReplicationCoordinator::set(service, std::move(replCoord));
+
+    _storage = stdx::make_unique<repl::StorageInterfaceImpl>();
+}
+
+void CappedUtilsTest::tearDown() {
+    _storage = {};
+
+    // Tear down mongod.
+    ServiceContextMongoDTest::tearDown();
+}
+
+/**
+ * Creates an OperationContext.
+ */
+ServiceContext::UniqueOperationContext makeOpCtx() {
+    return cc().makeOperationContext();
+}
+
+/**
+ * Returns true if collection exists.
+ */
+bool collectionExists(OperationContext* opCtx, const NamespaceString& nss) {
+    return AutoGetCollectionForRead(opCtx, nss).getCollection() != nullptr;
+}
+
+/**
+ * Returns collection options.
+ */
+CollectionOptions getCollectionOptions(OperationContext* opCtx, const NamespaceString& nss) {
+    AutoGetCollectionForRead autoColl(opCtx, nss);
+    auto collection = autoColl.getCollection();
+    ASSERT_TRUE(collection) << "Unable to get collections options for " << nss
+                            << " because collection does not exist.";
+    auto catalogEntry = collection->getCatalogEntry();
+    return catalogEntry->getCollectionOptions(opCtx);
+}
+
+// Size of capped collection to be passed to convertToCapped() which accepts a double.
+// According to documentation, the size (in bytes) of capped collection must be a minimum of 4096
+// and a multiple of 256.
+const double cappedCollectionSize = 8192.0;
+
+TEST_F(CappedUtilsTest, ConvertToCappedReturnsNamespaceNotFoundIfCollectionIsMissing) {
+    NamespaceString nss("test.t");
+    auto opCtx = makeOpCtx();
+    ASSERT_FALSE(collectionExists(opCtx.get(), nss));
+    ASSERT_EQUALS(ErrorCodes::NamespaceNotFound, convertToCapped(opCtx.get(), nss, 1000.0));
+}
+
+TEST_F(CappedUtilsTest, ConvertToCappedUpdatesCollectionOptionsOnSuccess) {
+    NamespaceString nss("test.t");
+
+    auto opCtx = makeOpCtx();
+    ASSERT_OK(_storage->createCollection(opCtx.get(), nss, {}));
+    auto options = getCollectionOptions(opCtx.get(), nss);
+    ASSERT_FALSE(options.capped);
+
+    ASSERT_OK(convertToCapped(opCtx.get(), nss, cappedCollectionSize));
+    options = getCollectionOptions(opCtx.get(), nss);
+    ASSERT_TRUE(options.capped);
+    ASSERT_APPROX_EQUAL(cappedCollectionSize, options.cappedSize, 0.001)
+        << "unexpected capped collection size: " << options.toBSON();
+}
+
+TEST_F(CappedUtilsTest, ConvertToCappedReturnsNamespaceNotFoundIfCollectionIsDropPending) {
+    NamespaceString nss("test.t");
+    repl::OpTime dropOpTime(Timestamp(Seconds(100), 0), 1LL);
+    auto dropPendingNss = nss.makeDropPendingNamespace(dropOpTime);
+
+    auto opCtx = makeOpCtx();
+    ASSERT_OK(_storage->createCollection(opCtx.get(), dropPendingNss, {}));
+    auto options = getCollectionOptions(opCtx.get(), dropPendingNss);
+    ASSERT_FALSE(options.capped);
+
+    // Before SERVER-32098, convertToCapped() would reject writes to a drop-pending collection
+    // because the namespace contained ".system.".
+    ASSERT_EQUALS(ErrorCodes::BadValue,
+                  convertToCapped(opCtx.get(), dropPendingNss, cappedCollectionSize));
+    options = getCollectionOptions(opCtx.get(), dropPendingNss);
+    ASSERT_FALSE(options.capped);
+}
+
+}  // namespace