summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorBen Caimano <ben.caimano@10gen.com>2018-09-04 16:35:29 -0400
committerBen Caimano <ben.caimano@10gen.com>2018-09-06 13:11:13 -0400
commita54264b53097556622e5e8e823bfacabd39ee1e7 (patch)
tree3e5018e653bdb0d37da81174449523945496a604 /src
parent8aadacefd8c3f3507d519e60c2e7d8ef7f2f29bb (diff)
downloadmongo-a54264b53097556622e5e8e823bfacabd39ee1e7.tar.gz
SERVER-27588 Warning to disable defrag of transparent_hugepages when thp is disabled
Diffstat (limited to 'src')
-rw-r--r--src/mongo/db/startup_warnings_mongod.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/mongo/db/startup_warnings_mongod.cpp b/src/mongo/db/startup_warnings_mongod.cpp
index 9dcd4e387f6..b4ed61ff1cc 100644
--- a/src/mongo/db/startup_warnings_mongod.cpp
+++ b/src/mongo/db/startup_warnings_mongod.cpp
@@ -257,8 +257,12 @@ void logMongodStartupWarnings(const StorageGlobalParams& storageParams,
// Transparent Hugepages checks
StatusWith<std::string> transparentHugePagesEnabledResult =
StartupWarningsMongod::readTransparentHugePagesParameter("enabled");
+ bool shouldWarnAboutDefragAlways = false;
if (transparentHugePagesEnabledResult.isOK()) {
if (transparentHugePagesEnabledResult.getValue() == "always") {
+ // If we do not have hugepages enabled, we don't need to warn about its features
+ shouldWarnAboutDefragAlways = true;
+
log() << startupWarningsLog;
log() << "** WARNING: " << kTransparentHugePagesDirectory << "/enabled is 'always'."
<< startupWarningsLog;
@@ -274,7 +278,7 @@ void logMongodStartupWarnings(const StorageGlobalParams& storageParams,
StatusWith<std::string> transparentHugePagesDefragResult =
StartupWarningsMongod::readTransparentHugePagesParameter("defrag");
- if (transparentHugePagesDefragResult.isOK()) {
+ if (shouldWarnAboutDefragAlways && transparentHugePagesDefragResult.isOK()) {
if (transparentHugePagesDefragResult.getValue() == "always") {
log() << startupWarningsLog;
log() << "** WARNING: " << kTransparentHugePagesDirectory << "/defrag is 'always'."