WT-3136 bug fix: WiredTiger doesn't check sprintf calls for error return (#3340)

* WT-3136 bug fix: WiredTiger doesn't check sprintf calls for error return

Make a pass through the source base to check sprintf, snprintf, vsprintf
and vsnprintf calls for errors.

* A WiredTiger key is a uint64_t.
Use sizeof(), don't hard-wire buffer sizes into the code.

* More (u_int) vs. (uint64_t) fixes.

* Use CONFIG_APPEND instead of FORMAT_APPEND, it makes more sense.

* revert part of 4475ae9, there's an explicit allocation of the size of
the buffer.

* MVSC complaints:
test\format\config.c(765): warning C4018: '<': signed/unsigned mismatch
test\format\config.c(765): warning C4018: '>': signed/unsigned mismatch

* Change Windows testing shim to correctly use __wt_snprintf

* Change Windows test shim to use the __wt_XXX functions

* MSDN's _vscprintf API returns the number of characters excluding the
termininating nul byte, return that value.

1 files changed, 2 insertions, 6 deletions

diff --git a/test/thread/t.c b/test/thread/t.c
index 9dfd02bdad2..d2ed4c74bb7 100644
--- a/test/thread/t.c
+++ b/test/thread/t.c
@@ -185,19 +185,15 @@ wt_connect(char *config_open)
 	};
 	int ret;
 	char config[512];
-	size_t print_count;
 
 	testutil_clean_work_dir(home);
 	testutil_make_work_dir(home);
 
-	print_count = (size_t)snprintf(config, sizeof(config),
+	testutil_check(__wt_snprintf(config, sizeof(config),
 	    "create,statistics=(all),error_prefix=\"%s\",%s%s",
 	    progname,
 	    config_open == NULL ? "" : ",",
-	    config_open == NULL ? "" : config_open);
-
-	if (print_count >= sizeof(config))
-		testutil_die(EINVAL, "Config string too long");
+	    config_open == NULL ? "" : config_open));
 
 	if ((ret = wiredtiger_open(home, &event_handler, config, &conn)) != 0)
 		testutil_die(ret, "wiredtiger_open");