1 files changed, 65 insertions, 68 deletions
diff --git a/jstests/core/txns/upconvert_read_concern.js b/jstests/core/txns/upconvert_read_concern.js
index 15d166dde08..2f49280e128 100644
--- a/jstests/core/txns/upconvert_read_concern.js
+++ b/jstests/core/txns/upconvert_read_concern.js
@@ -2,97 +2,94 @@
 // 'snapshot'.
 // @tags: [uses_transactions]
 (function() {
-    "use strict";
+"use strict";
 
-    const dbName = "test";
-    const collName = "upconvert_read_concern";
-    const testDB = db.getSiblingDB(dbName);
-    const testColl = testDB[collName];
+const dbName = "test";
+const collName = "upconvert_read_concern";
+const testDB = db.getSiblingDB(dbName);
+const testColl = testDB[collName];
 
-    testDB.runCommand({drop: collName, writeConcern: {w: "majority"}});
+testDB.runCommand({drop: collName, writeConcern: {w: "majority"}});
 
-    assert.commandWorked(
-        testDB.createCollection(testColl.getName(), {writeConcern: {w: "majority"}}));
+assert.commandWorked(testDB.createCollection(testColl.getName(), {writeConcern: {w: "majority"}}));
 
-    const sessionOptions = {causalConsistency: false};
-    const session = db.getMongo().startSession(sessionOptions);
-    const sessionDb = session.getDatabase(dbName);
+const sessionOptions = {
+    causalConsistency: false
+};
+const session = db.getMongo().startSession(sessionOptions);
+const sessionDb = session.getDatabase(dbName);
 
-    function testUpconvertReadConcern(readConcern) {
-        jsTest.log("Test that the following readConcern is upconverted: " + tojson(readConcern));
-        assert.commandWorked(testColl.remove({}, {writeConcern: {w: "majority"}}));
+function testUpconvertReadConcern(readConcern) {
+    jsTest.log("Test that the following readConcern is upconverted: " + tojson(readConcern));
+    assert.commandWorked(testColl.remove({}, {writeConcern: {w: "majority"}}));
 
-        // Start a new transaction with the given readConcern.
-        session.startTransaction();
-        let command = {find: collName};
-        if (readConcern) {
-            Object.extend(command, {readConcern: readConcern});
-        }
-        assert.commandWorked(sessionDb.runCommand(command));
+    // Start a new transaction with the given readConcern.
+    session.startTransaction();
+    let command = {find: collName};
+    if (readConcern) {
+        Object.extend(command, {readConcern: readConcern});
+    }
+    assert.commandWorked(sessionDb.runCommand(command));
 
-        // Insert a document outside of the transaction.
-        assert.commandWorked(testColl.insert({_id: 0}, {writeConcern: {w: "majority"}}));
+    // Insert a document outside of the transaction.
+    assert.commandWorked(testColl.insert({_id: 0}, {writeConcern: {w: "majority"}}));
 
-        // Test that the transaction does not see the new document (it has snapshot isolation).
-        let res = assert.commandWorked(sessionDb.runCommand({find: collName}));
-        assert.eq(res.cursor.firstBatch.length, 0, tojson(res));
+    // Test that the transaction does not see the new document (it has snapshot isolation).
+    let res = assert.commandWorked(sessionDb.runCommand({find: collName}));
+    assert.eq(res.cursor.firstBatch.length, 0, tojson(res));
 
-        // Commit the transaction.
-        assert.commandWorked(session.commitTransaction_forTesting());
-    }
-
-    testUpconvertReadConcern(null);
-    testUpconvertReadConcern({});
-    testUpconvertReadConcern({level: "local"});
-    testUpconvertReadConcern({level: "majority"});
-    testUpconvertReadConcern({level: "snapshot"});
-
-    function testCannotUpconvertReadConcern(readConcern) {
-        jsTest.log("Test that the following readConcern cannot be upconverted: " + readConcern);
-
-        // Start a new transaction with the given readConcern.
-        session.startTransaction();
-        assert.commandFailedWithCode(
-            sessionDb.runCommand({find: collName, readConcern: readConcern}),
-            ErrorCodes.InvalidOptions);
-
-        // No more operations are allowed in the transaction.
-        assert.commandFailedWithCode(sessionDb.runCommand({find: collName}),
-                                     ErrorCodes.NoSuchTransaction);
-        assert.commandFailedWithCode(session.abortTransaction_forTesting(),
-                                     ErrorCodes.NoSuchTransaction);
-    }
+    // Commit the transaction.
+    assert.commandWorked(session.commitTransaction_forTesting());
+}
 
-    testCannotUpconvertReadConcern({level: "available"});
-    testCannotUpconvertReadConcern({level: "linearizable"});
+testUpconvertReadConcern(null);
+testUpconvertReadConcern({});
+testUpconvertReadConcern({level: "local"});
+testUpconvertReadConcern({level: "majority"});
+testUpconvertReadConcern({level: "snapshot"});
 
-    jsTest.log("Test starting a transaction with an invalid readConcern");
+function testCannotUpconvertReadConcern(readConcern) {
+    jsTest.log("Test that the following readConcern cannot be upconverted: " + readConcern);
 
     // Start a new transaction with the given readConcern.
     session.startTransaction();
-    assert.commandFailedWithCode(
-        sessionDb.runCommand({find: collName, readConcern: {level: "bad"}}),
-        ErrorCodes.FailedToParse);
+    assert.commandFailedWithCode(sessionDb.runCommand({find: collName, readConcern: readConcern}),
+                                 ErrorCodes.InvalidOptions);
 
     // No more operations are allowed in the transaction.
     assert.commandFailedWithCode(sessionDb.runCommand({find: collName}),
                                  ErrorCodes.NoSuchTransaction);
     assert.commandFailedWithCode(session.abortTransaction_forTesting(),
                                  ErrorCodes.NoSuchTransaction);
+}
 
-    jsTest.log("Test specifying readConcern on the second statement in a transaction");
+testCannotUpconvertReadConcern({level: "available"});
+testCannotUpconvertReadConcern({level: "linearizable"});
 
-    // Start a new transaction with snapshot readConcern.
-    session.startTransaction();
-    assert.commandWorked(sessionDb.runCommand({find: collName, readConcern: {level: "snapshot"}}));
+jsTest.log("Test starting a transaction with an invalid readConcern");
 
-    // The second statement cannot specify a readConcern.
-    assert.commandFailedWithCode(
-        sessionDb.runCommand({find: collName, readConcern: {level: "snapshot"}}),
-        ErrorCodes.InvalidOptions);
+// Start a new transaction with the given readConcern.
+session.startTransaction();
+assert.commandFailedWithCode(sessionDb.runCommand({find: collName, readConcern: {level: "bad"}}),
+                             ErrorCodes.FailedToParse);
 
-    // The transaction is still active and can be committed.
-    assert.commandWorked(session.commitTransaction_forTesting());
+// No more operations are allowed in the transaction.
+assert.commandFailedWithCode(sessionDb.runCommand({find: collName}), ErrorCodes.NoSuchTransaction);
+assert.commandFailedWithCode(session.abortTransaction_forTesting(), ErrorCodes.NoSuchTransaction);
+
+jsTest.log("Test specifying readConcern on the second statement in a transaction");
+
+// Start a new transaction with snapshot readConcern.
+session.startTransaction();
+assert.commandWorked(sessionDb.runCommand({find: collName, readConcern: {level: "snapshot"}}));
+
+// The second statement cannot specify a readConcern.
+assert.commandFailedWithCode(
+    sessionDb.runCommand({find: collName, readConcern: {level: "snapshot"}}),
+    ErrorCodes.InvalidOptions);
+
+// The transaction is still active and can be committed.
+assert.commandWorked(session.commitTransaction_forTesting());
 
-    session.endSession();
+session.endSession();
 }());