1 files changed, 149 insertions, 0 deletions
diff --git a/jstests/replsets/drop_databases_two_phase.js b/jstests/replsets/drop_databases_two_phase.js
new file mode 100644
index 00000000000..aa4aae61b82
--- /dev/null
+++ b/jstests/replsets/drop_databases_two_phase.js
@@ -0,0 +1,149 @@
+/**
+ * Test to ensure that two phase drop behavior for databases on replica sets works properly.
+ *
+ * Uses a 3 node replica set with one arbiter to verify both phases of a 2-phase database drop:
+ * the 'Collections' and 'Database' phase. Executing a 'dropDatabase' command should put that
+ * database into a drop-pending state. In this state, all new collection creation requests will
+ * be rejected with an error with the code ErrorCodes.DatabaseDropPending. We will exit the
+ * 'Collections' phase once the last collection drop has been propagated to a majority. All
+ * collections in the database will be physically dropped at this point.
+ *
+ * During the 'Database' phase, collection creation is still disallowed. This phase removes the
+ * metadata for the database from the server and appends the 'dropDatabase' operation to the oplog.
+ * Unlike the 'Collections' phase, we do not wait for the 'dropDatabase' to propagate to a majority
+ * unless explicitly requested by the user with a write concern.
+ */
+
+(function() {
+    "use strict";
+
+    // Returns a list of all collections in a given database. Use 'args' as the
+    // 'listCollections' command arguments.
+    function listCollections(database, args) {
+        var args = args || {};
+        var failMsg = "'listCollections' command failed";
+        var res = assert.commandWorked(database.runCommand("listCollections", args), failMsg);
+        return res.cursor.firstBatch;
+    }
+
+    // Returns a list of 'drop-pending' collections. The collection names should be of the
+    // format "system.drop.<optime>.<collectionName>", where 'optime' is the optime of the
+    // collection drop operation, encoded as a string, and 'collectionName' is the original
+    // collection name.
+    function listDropPendingCollections(database) {
+        var pendingDropRegex = new RegExp("system\.drop\..*\." + collNameToDrop + "$");
+        var collections = listCollections(database, {includePendingDrops: true});
+        return collections.filter(c => pendingDropRegex.test(c.name));
+    }
+
+    // Returns a list of all collection names in a given database.
+    function listCollectionNames(database, args) {
+        return listCollections(database, args).map(c => c.name);
+    }
+
+    // Sets a fail point on a specified node.
+    function setFailPoint(node, failpoint, mode) {
+        assert.commandWorked(node.adminCommand({configureFailPoint: failpoint, mode: mode}));
+    }
+
+    var dbNameToDrop = 'dbToDrop';
+    var replTest = new ReplSetTest({nodes: [{}, {}, {arbiter: true}]});
+
+    // Initiate the replica set.
+    replTest.startSet();
+    replTest.initiate();
+    replTest.awaitReplication();
+
+    var primary = replTest.getPrimary();
+    var secondary = replTest.getSecondary();
+
+    var dbToDrop = primary.getDB(dbNameToDrop);
+    var collNameToDrop = "collectionToDrop";
+
+    // Create the collection that will be dropped and let it replicate.
+    var collToDrop = dbToDrop.getCollection(collNameToDrop);
+    assert.writeOK(
+        collToDrop.insert({_id: 0}, {writeConcern: {w: 2, wtimeout: replTest.kDefaultTimeoutMS}}));
+    assert.eq(1, collToDrop.find().itcount());
+
+    // Pause application on secondary so that commit point doesn't advance, meaning that a dropped
+    // database on the primary will remain in 'drop-pending' state.
+    jsTestLog("Pausing oplog application on the secondary node.");
+    setFailPoint(secondary, "rsSyncApplyStop", "alwaysOn");
+
+    // Make sure the collection was created.
+    assert.contains(collNameToDrop,
+                    listCollectionNames(dbToDrop),
+                    "Collection '" + collNameToDrop + "' wasn't created properly");
+
+    /**
+     * DROP DATABASE 'Collections' PHASE
+     */
+
+    // Drop the collection on the primary.
+    var dropDatabaseFn = function() {
+        var dbNameToDrop = 'dbToDrop';
+        var primary = db.getMongo();
+        jsTestLog(
+            'Dropping database ' + dbNameToDrop + ' on primary node ' + primary.host +
+            '. This command will block because oplog application is paused on the secondary.');
+        var dbToDrop = db.getSiblingDB(dbNameToDrop);
+        assert.commandWorked(dbToDrop.dropDatabase());
+        jsTestLog('Database ' + dbNameToDrop + ' successfully dropped on primary node ' +
+                  primary.host);
+    };
+    var dropDatabaseProcess = startParallelShell(dropDatabaseFn, primary.port);
+
+    // Check that primary has started two phase drop of the collection.
+    jsTestLog('Waiting for primary ' + primary.host + ' to prepare two phase drop of collection ' +
+              collToDrop.getFullName());
+    assert.soonNoExcept(
+        function() {
+            return collToDrop.find().itcount() == 0;
+        },
+        'Primary ' + primary.host + ' failed to prepare two phase drop of collection ' +
+            collToDrop.getFullName());
+    var dropPendingCollections = listDropPendingCollections(dbToDrop);
+    assert.eq(1,
+              dropPendingCollections.length,
+              "Collection was not found in the 'system.drop' namespace. " +
+                  "Full drop-pending collection list: " + tojson(dropPendingCollections));
+    jsTestLog('Primary ' + primary.host + ' successfully started two phase drop of collection ' +
+              collToDrop.getFullName());
+
+    // Collection creation should fail with an error of ErrorCodes.DatabaseDropPending while the
+    // database is in a drop pending state.
+    assert.commandFailedWithCode(
+        dbToDrop.createCollection('collectionToCreateWhileDroppingDatabase'),
+        ErrorCodes.DatabaseDropPending,
+        'collection creation should fail while we are in the process of dropping the database');
+
+    /**
+     * DROP DATABASE 'Database' PHASE
+     */
+
+    // Let the secondary apply the collection drop operation, so that the replica set commit point
+    // will advance, and the 'Database' phase of the database drop will complete on the primary.
+    jsTestLog("Restarting oplog application on the secondary node.");
+    setFailPoint(secondary, "rsSyncApplyStop", "off");
+
+    jsTestLog("Waiting for collection drop operation to replicate to all nodes.");
+    replTest.awaitReplication();
+
+    // Make sure the collection has been fully dropped. It should not appear as
+    // a normal collection or under the 'system.drop' namespace any longer. Physical collection
+    // drops may happen asynchronously, any time after the drop operation is committed, so we wait
+    // to make sure the collection is eventually dropped.
+    assert.soonNoExcept(function() {
+        var dropPendingCollections = listDropPendingCollections(dbToDrop);
+        jsTestLog('Drop pending collections: ' + tojson(dropPendingCollections));
+        return dropPendingCollections.length == 0;
+    });
+
+    jsTestLog('Waiting for dropDatabase command on ' + primary.host + ' to complete.');
+    var exitCode = dropDatabaseProcess();
+    assert.eq(0, exitCode, 'dropDatabase command on ' + primary.host + ' failed.');
+    jsTestLog('Completed dropDatabase command on ' + primary.host);
+
+    replTest.stopSet();
+}());