diff options
Diffstat (limited to 'src/mongo/db/query/canonical_query_test.cpp')
-rw-r--r-- | src/mongo/db/query/canonical_query_test.cpp | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/src/mongo/db/query/canonical_query_test.cpp b/src/mongo/db/query/canonical_query_test.cpp index d3fb9a55fd4..8036dac3adb 100644 --- a/src/mongo/db/query/canonical_query_test.cpp +++ b/src/mongo/db/query/canonical_query_test.cpp @@ -35,7 +35,6 @@ namespace mongo { namespace { using std::string; -using std::unique_ptr; using unittest::assertGet; static const char* ns = "somebogusns"; @@ -52,6 +51,7 @@ MatchExpression* parseMatchExpression(const BSONObj& obj) { << ". Reason: " << status.getStatus().toString(); FAIL(ss); } + return status.getValue(); } @@ -62,8 +62,7 @@ MatchExpression* parseMatchExpression(const BSONObj& obj) { */ Status isValid(const std::string& queryStr, const LiteParsedQuery& lpqRaw) { BSONObj queryObj = fromjson(queryStr); - std::unique_ptr<MatchExpression> me( - CanonicalQuery::normalizeTree(parseMatchExpression(queryObj))); + unique_ptr<MatchExpression> me(CanonicalQuery::normalizeTree(parseMatchExpression(queryObj))); return CanonicalQuery::isValid(me.get(), lpqRaw); } @@ -461,22 +460,22 @@ TEST(CanonicalQueryTest, SortTreeNumChildrenComparison) { /** * Utility function to create a CanonicalQuery */ -CanonicalQuery* canonicalize(const char* queryStr) { +unique_ptr<CanonicalQuery> canonicalize(const char* queryStr) { BSONObj queryObj = fromjson(queryStr); - CanonicalQuery* cq; - Status result = CanonicalQuery::canonicalize(ns, queryObj, &cq); - ASSERT_OK(result); - return cq; + auto statusWithCQ = CanonicalQuery::canonicalize(ns, queryObj); + ASSERT_OK(statusWithCQ.getStatus()); + return std::move(statusWithCQ.getValue()); } -CanonicalQuery* canonicalize(const char* queryStr, const char* sortStr, const char* projStr) { +std::unique_ptr<CanonicalQuery> canonicalize(const char* queryStr, + const char* sortStr, + const char* projStr) { BSONObj queryObj = fromjson(queryStr); BSONObj sortObj = fromjson(sortStr); BSONObj projObj = fromjson(projStr); - CanonicalQuery* cq; - Status result = CanonicalQuery::canonicalize(ns, queryObj, sortObj, projObj, &cq); - ASSERT_OK(result); - return cq; + auto statusWithCQ = CanonicalQuery::canonicalize(ns, queryObj, sortObj, projObj); + ASSERT_OK(statusWithCQ.getStatus()); + return std::move(statusWithCQ.getValue()); } // Don't do anything with a double OR. |