diff options
Diffstat (limited to 'src/mongo/db/repl/replication_coordinator_impl.cpp')
-rw-r--r-- | src/mongo/db/repl/replication_coordinator_impl.cpp | 33 |
1 files changed, 3 insertions, 30 deletions
diff --git a/src/mongo/db/repl/replication_coordinator_impl.cpp b/src/mongo/db/repl/replication_coordinator_impl.cpp index 027a75ba474..310bef218a3 100644 --- a/src/mongo/db/repl/replication_coordinator_impl.cpp +++ b/src/mongo/db/repl/replication_coordinator_impl.cpp @@ -63,6 +63,7 @@ #include "mongo/db/kill_sessions_local.h" #include "mongo/db/mongod_options_storage_gen.h" #include "mongo/db/prepare_conflict_tracker.h" +#include "mongo/db/repl/always_allow_non_local_writes.h" #include "mongo/db/repl/check_quorum_for_config_change.h" #include "mongo/db/repl/data_replicator_external_state_initial_sync.h" #include "mongo/db/repl/is_master_response.h" @@ -174,34 +175,6 @@ using NextAction = Fetcher::NextAction; namespace { const char kLocalDB[] = "local"; -// Overrides _canAcceptLocalWrites for the decorated OperationContext. -const OperationContext::Decoration<bool> alwaysAllowNonLocalWrites = - OperationContext::declareDecoration<bool>(); - -/** - * Allows non-local writes despite _canAcceptNonLocalWrites being false on a single OperationContext - * while in scope. - * - * Resets to original value when leaving scope so it is safe to nest. - */ -class AllowNonLocalWritesBlock { - AllowNonLocalWritesBlock(const AllowNonLocalWritesBlock&) = delete; - AllowNonLocalWritesBlock& operator=(const AllowNonLocalWritesBlock&) = delete; - -public: - AllowNonLocalWritesBlock(OperationContext* opCtx) - : _opCtx(opCtx), _initialState(alwaysAllowNonLocalWrites(_opCtx)) { - alwaysAllowNonLocalWrites(_opCtx) = true; - } - - ~AllowNonLocalWritesBlock() { - alwaysAllowNonLocalWrites(_opCtx) = _initialState; - } - -private: - OperationContext* const _opCtx; - const bool _initialState; -}; void lockAndCall(stdx::unique_lock<Latch>* lk, const std::function<void()>& fn) { if (!lk->owns_lock()) { @@ -2843,7 +2816,7 @@ bool ReplicationCoordinatorImpl::canAcceptWritesForDatabase_UNSAFE(OperationCont // // Stand-alone nodes and drained replica set primaries can always accept writes. Writes are // always permitted to the "local" database. - if (_readWriteAbility->canAcceptNonLocalWrites_UNSAFE() || alwaysAllowNonLocalWrites(*opCtx)) { + if (_readWriteAbility->canAcceptNonLocalWrites_UNSAFE() || alwaysAllowNonLocalWrites(opCtx)) { return true; } if (dbName == kLocalDB) { @@ -2888,7 +2861,7 @@ bool ReplicationCoordinatorImpl::canAcceptWritesFor_UNSAFE(OperationContext* opC // If we can accept non local writes (ie we're PRIMARY) then we must not be in ROLLBACK. // This check is redundant of the check of _memberState below, but since this can be checked // without locking, we do it as an optimization. - if (_readWriteAbility->canAcceptNonLocalWrites_UNSAFE() || alwaysAllowNonLocalWrites(*opCtx)) { + if (_readWriteAbility->canAcceptNonLocalWrites_UNSAFE() || alwaysAllowNonLocalWrites(opCtx)) { return true; } |