| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
| |
This change makes the logical sessions cache query and reap sessions,
which are possibly only in-memory on the SessionsCatalog.
|
| |
|
|
|
|
| |
direct writes to `config.transactions`
|
|
|
|
|
|
| |
This change folds the TransactionReaper's single function to be part of
the SessionCatalogs on MongoD and MongoS, which are the subsystems
responsible for managing transactions.
|
| |
|
| |
|
|
|
|
| |
This reverts commit 04ea1d46eb6c4c78e19409f120ae2e61f2a35204.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mutexes in TransactionParticipant
This type simplifies and clarifies concurrency control in TransactionParticipant by:
(1) Removing TP's own mutexes and using the Session concurrency control rules,
instead. That is, certain state is only accessible when the Session is checked
out, and requires no further locking. Other state is observable either while
holding the client lock or while having checked out the Session. The latter type
of state is modifiable only when having checked out the session and locked the
client.
(2) Separating the two types of state in (1) into separate sub-structures in
TransactionParticipant, to make it clear who can access what state,
(3) Putting all methods formerly on TransactionParticipant onto new member
classes, TransactionParticipant::Participant and
TransactionParticipant::Observer. The latter can only read the observable state
from (1) above, and the participant may read or modify all of the state.
The two types introduced by (3) are designed to enforce proper concurrency
control by limiting access of their methods to the underlying
TransactionParticipant member variables. The observer type has a private o()
method which its other methods are required by convention to use in order to
obtain read-only access to the Observable state of the
TransactionParticipant. The participant type has the o() method plus an
o(WithLock) method that allows mutation of the state while holding the client
lock, and a p() method which allows reading and writing of the private state
with no other locks. Please see the implementation in
transaction_participant.cpp for examples.
It is worth noting that with this change, locking the Client is not needed often
and never for long, and there is no need for separate mutexes for participant
state and monitoring state.
|
|
|
|
|
|
| |
Remove leading comments that are just stating the filename.
Move any file-level comments below the copyright banner.
Remove leading blank lines.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces two new types for gaining access to sessions in
the session catalog, based on the context of the access. It leaves a
third way to access sessions, which is via
OperationContextSession::get().
The new types are ObservableSession and SessionToKill. With this
change, a thread may access a session in one of three ways:
(1) by binding the session to an OperationContext for regular use, by
instantiation of OperationContextSession or
MongoDOperationContextSession, as before.
(2) In the callback passed to SessionCatalog::scanSessions, in which
case the callback is passed an ObservableSession that represents
looking at a Session while the SessionCatalog mutex is locked and
while the bound OperationContext's client mutex is held, if the
session is currently checked out via methods (1) or (3).
(3) By calling SessionCatalog::checkOutSessionForKill, which returns a
KillableSession. This is used for cleaning a session up after it is
marked for kill.
This patch eliminates Session::_mutex, which is no longer required, as
the SessionCatalog::_mutex and the Client provide all necessary mutual
exclusion for the Session type itself.
|
| |
|
|
|
|
| |
checkStatementExecuted
|
| |
|
| |
|
|
|
|
| |
becomes primary
|
|
|
|
| |
be just get(Session*)
|
|
|
|
|
|
|
| |
The session catalog should not be accessed directly by majority of the
consumers on mongod or mongos, instead they should interact with it
through the decorations, which properly validate that the session has
been assigned to the OperationContext.
|
|
|
|
|
|
|
|
|
|
|
| |
OperationContextSession
This simplifies the behaviour of the class and moves all the check-out
decision taking to happen in the only consumer - the endpoint.
Also renames OperationContextSessionMongoD to MongoDOperationContextSession
in order to be in sync with the naming nomenclature of SessionCatalog and
MongoDSessionCatalog.
|
|
|
|
| |
MongoDSessionCatalog
|
|
|
|
| |
Session/TransactionParticipant object
|
| |
|
|
|