| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
This reverts commit 55aa7926f29c141431ac4f23bfb5678044c40488.
* Fix key format for test to be recno, also fixes valgrind to not fail.
|
| |
|
|
|
|
|
| |
don't ignore return values from routines that can fail
don't use %u to format uint32_t's or ints
KNF
|
|
|
|
|
|
|
|
|
|
|
| |
Coverity complains:
CID 1356929: Incorrect expression (ASSERT_SIDE_EFFECT)
Assignment "tablename = strchr(opts->uri, 58)" has a side effect.
This code will work differently in a non-debug build.
90 testutil_assert((tablename = strchr(opts->uri, ':')) != 0);
I don't see it (there aren't any #ifdefs in the path to exit), my
suspicion is Coverity doesn't like side-effects in function calls
named with any variant of "assert".
|
|
|
|
| |
test/csuite/wt2592_join_schema/main.c:79:14: error: declaration of ‘basename’ shadows a global declaration [-Werror=shadow]
|
| |
|
|
|
|
|
|
| |
Add the --enable-strict option that uses our current best guess at the right flags for strict compilation.
While adding the option, expand the set of flags we can compile cleanly with.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* WT-2661: Coverity failures: 1356050-1356053
CID 1356050: (NULL_RETURNS)
Dereferencing a pointer that might be null "opts->home" when calling "snprintf".
CID 1356050: (NULL_RETURNS)
Dereferencing a pointer that might be null "opts->uri" when calling "snprintf".
* Assigning address of auto variable '_opts' to static (it's an auto
variable in main(), so it's safe, but make lint happy).
* Coverity appears to be confused by argv handling and eventually passing
NULL to snprintf.
2. var_assign_alias: Assigning: opts->progname = argv[0]. Both
are now tainted.
47. vararg_transitive: Call to snprintf with tainted argument
opts->progname taints NULL.
48. tainted_data_sink_lv_call: Passing tainted variable 0UL to
tainted data sink snprintf.
NULL is tainted? I'm hoping that using a strlen() call to figure out the
string length instead of snprintf() will make this one go away.
* test_wt2246_col_append wasn't actually doing any work, set nrecords to
a 20 million default.
* KNF
* Don't use "inline" in example programs, it requires Windows #ifdef's.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* WT-2659: csuite tests, assorted lint and cleanup.
Fail if memory allocation fails, ignore usleep() and pthread_join()
returns.
* Don't check for NULL before calling free, free does that for you.
* Convert (int) casts to the correct printf format string, KNF.
* Assert that ret == WT_NOTFOUND when exiting the WT_CURSOR.next loop
(Warning 438: Last value assigned to variable 'ret' (defined at line
122) not used).
Add testutil_assert macro to make it easy to assert boolean values.
* Explicit global initialization.
* Use correct printf format types instead of casting to (int), KNF.
* Remove unused variable.
* Fix testutil_assert() to lint cleanly.
* Assert various WiredTiger functions succeed.
|
| |
|
|
* WT-2554 Add initial C test framework.
With a few sample applications. Need to do further work to cleanup
the same applications and share as much code/style as possible.
* WT-2554 Fixup build errors.
* Fix compiler warning.
* Cleanup
* Ensure each test runs in a different directory.
* Update C test suite names and add copyright.
* Move test code into subdirectories.
* Replace test_util.i with a real utility library now that we have one.
Nothing needs to be an inline function.
Mostly cherry picked from 7c18420.
* Use WiredTiger getopt in C test suite for platform portability.
* Add a header comment to each test case.
* Add a C test suite entry auto generator
* Style, KNF
* Implement review feedback.
* Build test/utility library on Windows
* Add comment to script. Fix a printf.
|