From 99305a5414b8140472cc45e2aec926da5c7a0046 Mon Sep 17 00:00:00 2001 From: Keith Bostic Date: Wed, 26 Feb 2014 07:18:31 -0500 Subject: Fix typo when closing config_parser handle, complain if the config_parser.close method errors. --- ext/datasources/helium/helium.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ext/datasources/helium/helium.c b/ext/datasources/helium/helium.c index c8a6fe99bb0..cc420c89999 100644 --- a/ext/datasources/helium/helium.c +++ b/ext/datasources/helium/helium.c @@ -2102,7 +2102,7 @@ helium_session_open_cursor(WT_DATA_SOURCE *wtds, WT_SESSION *session, WT_CURSOR *wtcursor; WT_EXTENSION_API *wtext; WT_SOURCE *ws; - int locked, ret, t_ret; + int locked, ret, tret; const char *value; *new_cursor = NULL; @@ -2113,7 +2113,7 @@ helium_session_open_cursor(WT_DATA_SOURCE *wtds, WT_SESSION *session, wtext = ds->wtext; ws = NULL; locked = 0; - ret = t_ret = 0; + ret = tret = 0; value = NULL; /* Allocate and initialize a cursor. */ @@ -2227,9 +2227,11 @@ err: if (ws != NULL && locked) ESET(unlock(wtext, session, &ws->lock)); cursor_destroy(cursor); } - if (config_parser != NULL && (t_ret = - (void)config_parser->close(config_parser)) != 0 && ret == 0) - ret = t_ret; + if (config_parser != NULL && + (tret = config_parser->close(config_parser)) != 0) + EMSG(wtext, session, tret, + "WT_CONFIG_PARSER.close: %s", wtext->strerror(tret)); + free((void *)value); return (ret); } -- cgit v1.2.1