From c8dea9f922ce046e0ef3962a7384a5a6d964ab04 Mon Sep 17 00:00:00 2001 From: Sanika Phanse Date: Tue, 19 Apr 2022 17:20:09 +0000 Subject: SERVER-65635 Tests running large txns do not have correct oplog entry sizes (cherry picked from commit 6d5c93d1ada87cfdf55f1384508fe0f6d96dc86c) --- jstests/sharding/internal_txns/retryable_writes_basic.js | 6 +++++- jstests/sharding/internal_txns/retryable_writes_failover.js | 6 +++++- jstests/sharding/internal_txns/retryable_writes_oplog_entries.js | 6 +++++- jstests/sharding/internal_txns/retryable_writes_restart.js | 6 +++++- 4 files changed, 20 insertions(+), 4 deletions(-) diff --git a/jstests/sharding/internal_txns/retryable_writes_basic.js b/jstests/sharding/internal_txns/retryable_writes_basic.js index c43daf521a9..c95bb8c9121 100644 --- a/jstests/sharding/internal_txns/retryable_writes_basic.js +++ b/jstests/sharding/internal_txns/retryable_writes_basic.js @@ -2,7 +2,11 @@ * Tests that retryable internal transactions for insert, update and delete are retryable and * other kinds of transactions for insert, update and delete are not retryable. * - * @tags: [requires_fcv_60, uses_transactions] + * Exclude this test from large_txn variants because the variant enforces that the max transaction + * oplog entry length is 2 operations, and the oplog length assertions in this test do not account + * for this. We are not losing test coverage as this test inherently tests large transactions. + * + * @tags: [requires_fcv_60, uses_transactions, exclude_from_large_txns] */ (function() { 'use strict'; diff --git a/jstests/sharding/internal_txns/retryable_writes_failover.js b/jstests/sharding/internal_txns/retryable_writes_failover.js index 0bceaee46ba..5c22d733767 100644 --- a/jstests/sharding/internal_txns/retryable_writes_failover.js +++ b/jstests/sharding/internal_txns/retryable_writes_failover.js @@ -2,7 +2,11 @@ * Tests that retryable internal transactions for insert, update and delete are retryable across * failover. * - * @tags: [requires_fcv_60, uses_transactions] + * Exclude this test from large_txn variants because the variant enforces that the max transaction + * oplog entry length is 2 operations, and the oplog length assertions in this test do not account + * for this. We are not losing test coverage as this test inherently tests large transactions. + * + * @tags: [requires_fcv_60, uses_transactions, exclude_from_large_txns] */ (function() { 'use strict'; diff --git a/jstests/sharding/internal_txns/retryable_writes_oplog_entries.js b/jstests/sharding/internal_txns/retryable_writes_oplog_entries.js index 163fb4126fa..779fd97da98 100644 --- a/jstests/sharding/internal_txns/retryable_writes_oplog_entries.js +++ b/jstests/sharding/internal_txns/retryable_writes_oplog_entries.js @@ -2,7 +2,11 @@ * Tests that the stmtIds for write statements in an internal transaction for retryable writes * are stored in the individual operation entries in the applyOps oplog entry for the transaction. * - * @tags: [requires_fcv_60, uses_transactions] + * Exclude this test from large_txn variants because the variant enforces that the max transaction + * oplog entry length is 2 operations, and the oplog length assertions in this test do not account + * for this. We are not losing test coverage as this test inherently tests large transactionss. + * + * @tags: [requires_fcv_60, uses_transactions, exclude_from_large_txns] */ (function() { 'use strict'; diff --git a/jstests/sharding/internal_txns/retryable_writes_restart.js b/jstests/sharding/internal_txns/retryable_writes_restart.js index e1c3a6ba31c..a4a4e58c636 100644 --- a/jstests/sharding/internal_txns/retryable_writes_restart.js +++ b/jstests/sharding/internal_txns/retryable_writes_restart.js @@ -2,7 +2,11 @@ * Tests that retryable internal transactions for insert, update and delete are retryable across * restart. * - * @tags: [requires_fcv_60, uses_transactions, requires_persistence] + * Exclude this test from large_txn variants because the variant enforces that the max transaction + * oplog entry length is 2 operations, and the oplog length assertions in this test do not account + * for this. We are not losing test coverage as this test inherently tests large transactions. + * + * @tags: [requires_fcv_60, uses_transactions, requires_persistence, exclude_from_large_txns] */ (function() { 'use strict'; -- cgit v1.2.1