1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
|
#!/usr/bin/env python3
"""Simple C++ Linter."""
import argparse
import bisect
import io
import logging
import re
import sys
def _make_polyfill_regex():
polyfill_required_names = [
'_',
'adopt_lock',
'async',
'chrono',
'condition_variable',
'condition_variable_any',
'cv_status',
'defer_lock',
'future',
'future_status',
'get_terminate',
'launch',
'lock_guard',
'mutex',
'notify_all_at_thread_exit',
'packaged_task',
'promise',
'recursive_mutex',
'set_terminate',
'shared_lock',
'shared_mutex',
'shared_timed_mutex',
'this_thread(?!::at_thread_exit)',
'thread',
'timed_mutex',
'try_to_lock',
'unique_lock',
'unordered_map',
'unordered_multimap',
'unordered_multiset',
'unordered_set',
]
qualified_names = ['boost::' + name + "\\b" for name in polyfill_required_names]
qualified_names.extend('std::' + name + "\\b" for name in polyfill_required_names)
qualified_names_regex = '|'.join(qualified_names)
return re.compile('(' + qualified_names_regex + ')')
_RE_LINT = re.compile("//.*NOLINT")
_RE_COMMENT_STRIP = re.compile("//.*")
_RE_PATTERN_MONGO_POLYFILL = _make_polyfill_regex()
_RE_VOLATILE = re.compile('[^_]volatile')
_RE_MUTEX = re.compile('(^|[ ({,])stdx?::mutex[ ({]')
_RE_ASSERT = re.compile(r'\bassert\s*\(')
_RE_UNSTRUCTURED_LOG = re.compile(r'\blogd\s*\(')
_RE_STD_OPTIONAL = re.compile(r'\bstd::optional\b')
_RE_TRACING_SUPPORT = re.compile(r'\bTracerProvider::(get|initialize)\b')
_RE_GENERIC_FCV_COMMENT = re.compile(r'\(Generic FCV reference\):')
GENERIC_FCV = [
r'::kLatest',
r'::kLastContinuous',
r'::kLastLTS',
r'::kUpgradingFromLastLTSToLatest',
r'::kUpgradingFromLastContinuousToLatest',
r'::kDowngradingFromLatestToLastLTS',
r'::kDowngradingFromLatestToLastContinuous',
r'\.isUpgradingOrDowngrading',
r'::kDowngradingFromLatestToLastContinuous',
r'::kUpgradingFromLastLTSToLastContinuous',
]
_RE_GENERIC_FCV_REF = re.compile(r'(' + '|'.join(GENERIC_FCV) + r')\b')
class Linter:
"""Simple C++ Linter."""
_license_header = '''\
/**
* Copyright (C) {year}-present MongoDB, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the Server Side Public License, version 1,
* as published by MongoDB, Inc.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* Server Side Public License for more details.
*
* You should have received a copy of the Server Side Public License
* along with this program. If not, see
* <http://www.mongodb.com/licensing/server-side-public-license>.
*
* As a special exception, the copyright holders give permission to link the
* code of portions of this program with the OpenSSL library under certain
* conditions as described in each individual source file and distribute
* linked combinations including the program with the OpenSSL library. You
* must comply with the Server Side Public License in all respects for
* all of the code used other than as permitted herein. If you modify file(s)
* with this exception, you may extend this exception to your version of the
* file(s), but you are not obligated to do so. If you do not wish to do so,
* delete this exception statement from your version. If you delete this
* exception statement from all source files in the program, then also delete
* it in the license file.
*/'''.splitlines()
def __init__(self, file_name, raw_lines):
"""Create new linter."""
self.file_name = file_name
self.raw_lines = raw_lines
self.clean_lines = []
self.nolint_supression = []
self.generic_fcv_comments = []
self._error_count = 0
self.found_config_header = False
def lint(self):
"""Run linter, returning error count."""
# 3 steps:
# 1. Check for header
# 2. Check for NOLINT and Strip multi line comments
# 3. Run per-line checks
start_line = self._check_for_server_side_public_license()
self._check_newlines()
self._check_and_strip_comments()
for linenum in range(start_line, len(self.clean_lines)):
if not self.clean_lines[linenum]:
continue
self._check_for_mongo_volatile(linenum)
self._check_for_mongo_polyfill(linenum)
self._check_for_mongo_atomic(linenum)
self._check_for_mongo_mutex(linenum)
self._check_for_nonmongo_assert(linenum)
self._check_for_mongo_unstructured_log(linenum)
self._check_for_mongo_config_header(linenum)
self._check_for_ctype(linenum)
self._check_for_std_optional(linenum)
self._check_for_tracing_support(linenum)
# Relax the rule of commenting generic FCV references for files directly related to FCV
# implementations.
if not "feature_compatibility_version" in self.file_name:
self._check_for_generic_fcv(linenum)
return self._error_count
def _check_newlines(self):
"""Check that each source file ends with a newline character."""
if self.raw_lines and self.raw_lines[-1][-1:] != '\n':
self._error(
len(self.raw_lines), 'mongo/final_newline',
'Files must end with a newline character.')
def _check_and_strip_comments(self):
in_multi_line_comment = False
for linenum in range(len(self.raw_lines)):
clean_line = self.raw_lines[linenum]
# Users can write NOLINT different ways
# // NOLINT
# // Some explanation NOLINT
# so we need a regular expression
if _RE_LINT.search(clean_line):
self.nolint_supression.append(linenum)
if _RE_GENERIC_FCV_COMMENT.search(clean_line):
self.generic_fcv_comments.append(linenum)
if not in_multi_line_comment:
if "/*" in clean_line and not "*/" in clean_line:
in_multi_line_comment = True
clean_line = ""
# Trim comments - approximately
# Note, this does not understand if // is in a string
# i.e. it will think URLs are also comments but this should be good enough to find
# violators of the coding convention
if "//" in clean_line:
clean_line = _RE_COMMENT_STRIP.sub("", clean_line)
else:
if "*/" in clean_line:
in_multi_line_comment = False
clean_line = ""
self.clean_lines.append(clean_line)
def _check_for_mongo_volatile(self, linenum):
line = self.clean_lines[linenum]
if _RE_VOLATILE.search(line) and not "__asm__" in line:
self._error(
linenum, 'mongodb/volatile',
'Illegal use of the volatile storage keyword, use AtomicWord instead '
'from "mongo/platform/atomic_word.h"')
def _check_for_mongo_polyfill(self, linenum):
line = self.clean_lines[linenum]
match = _RE_PATTERN_MONGO_POLYFILL.search(line)
if match:
self._error(
linenum, 'mongodb/polyfill',
'Illegal use of banned name from std::/boost:: for "%s", use mongo::stdx:: variant instead'
% (match.group(0)))
def _check_for_mongo_atomic(self, linenum):
line = self.clean_lines[linenum]
if 'std::atomic' in line:
self._error(
linenum, 'mongodb/stdatomic',
'Illegal use of prohibited std::atomic<T>, use AtomicWord<T> or other types '
'from "mongo/platform/atomic_word.h"')
def _check_for_mongo_mutex(self, linenum):
line = self.clean_lines[linenum]
if _RE_MUTEX.search(line):
self._error(
linenum, 'mongodb/stdxmutex', 'Illegal use of prohibited stdx::mutex, '
'use mongo::Mutex from mongo/platform/mutex.h instead.')
def _check_for_nonmongo_assert(self, linenum):
line = self.clean_lines[linenum]
if _RE_ASSERT.search(line):
self._error(
linenum, 'mongodb/assert',
'Illegal use of the bare assert function, use a function from assert_utils.h instead.'
)
def _check_for_mongo_unstructured_log(self, linenum):
line = self.clean_lines[linenum]
if _RE_UNSTRUCTURED_LOG.search(line) or 'doUnstructuredLogImpl' in line:
self._error(
linenum, 'mongodb/unstructuredlog', 'Illegal use of unstructured logging, '
'this is only for local development use and should not be committed.')
def _check_for_ctype(self, linenum):
line = self.clean_lines[linenum]
if 'include <cctype>' in line or 'include <ctype.h>' in line:
self._error(linenum, 'mongodb/ctype',
'Use of prohibited <ctype.h> or <cctype> header, use "mongo/util/ctype.h"')
def _check_for_std_optional(self, linenum):
line = self.clean_lines[linenum]
if _RE_STD_OPTIONAL.search(line):
self._error(linenum, 'mongodb/stdoptional',
'Use of std::optional, use boost::optional instead.')
def _check_for_tracing_support(self, linenum):
line = self.clean_lines[linenum]
if _RE_TRACING_SUPPORT.search(line):
self._error(
linenum, 'mongodb/tracing', 'Illegal use of tracing support, '
'this is only for local development use and should not be committed.')
def _license_error(self, linenum, msg, category='legal/license'):
style_url = 'https://github.com/mongodb/mongo/wiki/Server-Code-Style'
self._error(linenum, category, '{} See {}'.format(msg, style_url))
return (False, linenum)
def _check_for_server_side_public_license(self):
"""Return the number of the line at which the check ended."""
src_iter = (x.rstrip() for x in self.raw_lines)
linenum = 0
for linenum, lic_line in enumerate(self._license_header):
src_line = next(src_iter, None)
if src_line is None:
self._license_error(linenum, 'Missing or incomplete license header.')
return linenum
lic_re = re.escape(lic_line).replace(r'\{year\}', r'\d{4}')
if not re.fullmatch(lic_re, src_line):
self._license_error(
linenum, 'Incorrect license header.\n'
' Expected: "{}"\n'
' Received: "{}"\n'.format(lic_line, src_line))
return linenum
# Warn if SSPL appears in Enterprise code, which has a different license.
expect_sspl_license = "enterprise" not in self.file_name
if not expect_sspl_license:
self._license_error(linenum,
'Incorrect license header found. Expected Enterprise license.',
category='legal/enterprise_license')
return linenum
return linenum
def _check_for_mongo_config_header(self, linenum):
"""Check for a config file."""
if self.found_config_header:
return
line = self.clean_lines[linenum]
self.found_config_header = line.startswith('#include "mongo/config.h"')
if not self.found_config_header and "MONGO_CONFIG_" in line:
self._error(linenum, 'build/config_h_include',
'MONGO_CONFIG define used without prior inclusion of config.h.')
def _check_for_generic_fcv(self, linenum):
line = self.clean_lines[linenum]
if _RE_GENERIC_FCV_REF.search(line):
# Find the first generic FCV comment preceding the current line.
i = bisect.bisect_right(self.generic_fcv_comments, linenum)
if not i or self.generic_fcv_comments[i - 1] < (linenum - 10):
self._error(
linenum, 'mongodb/fcv',
'Please add a comment containing "(Generic FCV reference):" within 10 lines ' +
'before the generic FCV reference.')
def _error(self, linenum, category, message):
if linenum in self.nolint_supression:
return
if category == "legal/license":
# Enterprise module does not have the SSPL license
if "enterprise" in self.file_name:
return
# The following files are in the src/mongo/ directory but technically belong
# in src/third_party/ because their copyright does not belong to MongoDB.
files_to_ignore = set([
'src/mongo/scripting/mozjs/PosixNSPR.cpp',
'src/mongo/shell/linenoise.cpp',
'src/mongo/shell/linenoise.h',
'src/mongo/shell/mk_wcwidth.cpp',
'src/mongo/shell/mk_wcwidth.h',
'src/mongo/util/md5.cpp',
'src/mongo/util/md5.h',
'src/mongo/util/md5main.cpp',
'src/mongo/util/net/ssl_stream.cpp',
'src/mongo/util/scopeguard.h',
])
norm_file_name = self.file_name.replace('\\', '/')
for file_to_ignore in files_to_ignore:
if file_to_ignore in norm_file_name:
return
# We count internally from 0 but users count from 1 for line numbers
print("Error: %s:%d - %s - %s" % (self.file_name, linenum + 1, category, message))
self._error_count += 1
def lint_file(file_name):
"""Lint file and print errors to console."""
with io.open(file_name, encoding='utf-8') as file_stream:
raw_lines = file_stream.readlines()
linter = Linter(file_name, raw_lines)
return linter.lint()
def main():
# type: () -> int
"""Execute Main Entry point."""
parser = argparse.ArgumentParser(description='MongoDB Simple C++ Linter.')
parser.add_argument('file', type=str, help="C++ input file")
parser.add_argument('-v', '--verbose', action='count', help="Enable verbose tracing")
args = parser.parse_args()
if args.verbose:
logging.basicConfig(level=logging.DEBUG)
try:
error_count = lint_file(args.file)
if error_count != 0:
print('File "{}" failed with {} errors.'.format(args.file, error_count))
return 1
return 0
except Exception as ex: # pylint: disable=broad-except
print('Exception while checking file "{}": {}'.format(args.file, ex))
return 2
if __name__ == '__main__':
sys.exit(main())
|